Conversation
|
Check out this pull request onΒ See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -6,7 +6,36 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
Suggest a slight rewording to remove salinity: "... Hovmoller plot of annual, globally-averaged anomalies of conservative temperature from..."
Reply via ReviewNB
| @@ -6,7 +6,36 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
Maybe before the "To convert to.." line, we should first specify that this script is written for MOM5 output.
Reply via ReviewNB
| @@ -6,7 +6,36 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
I wonder if we should update this to calculate the anomalies relative to the climatology, rather than the first year?
Although if the goal is to see model drift over time, then this current approach is appropriate. So maybe we can leave as it with this clarification ("this approach shows model drift over time").
Reply via ReviewNB
| @@ -6,7 +6,36 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
I don't think(?) the area of a grid cell varies with depth in MOM5 so perhaps for clarity we should remove that here.
Reply via ReviewNB
| @@ -6,7 +6,36 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
We could simplify this whole section and load the cell area variable directly (area_t) rather than calculating with dxt and dyt.
Reply via ReviewNB
| @@ -6,7 +6,36 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
| @@ -6,7 +6,36 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
Line #8. fig = plt.figure(figsize = (10, 6))
Now that the salinity subplot is removed, we could expand the width dimension to see more of the temporal changes.
Reply via ReviewNB
|
@KZCurtin how is this PR going? Have you had a chance to incorporate @hrsdawson's comments? Would be great to get this finished! |
Addressing the issues on the Hovmoller_Temperature_Depth notebook in 02_Appetisers (as per Hackathon issues list). I have:
Closes #595.
--
For tips on creating and reviewing pull requests, see
Some tips for reviewingon the documentation here.