Making Pre-supernova mass quantities accessible in the BPP file#703
Merged
Conversation
this fixes the test data
hopefully this matches the python versions on the github action runners
I think we are running into a numpy change specifically
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (82.46%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #703 +/- ##
===========================================
- Coverage 86.91% 78.46% -8.45%
===========================================
Files 40 49 +9
Lines 25542 27179 +1637
Branches 0 848 +848
===========================================
- Hits 22198 21325 -873
- Misses 3344 5582 +2238
- Partials 0 272 +272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…logging so that core masses are available at core collapse
KB PR to vera presnmass
…he iterator that goes up to 1e5 even though mc_co and mc_he are of size 2, so memory gets overwritten and eventually busses. rip
Kb fix segfault vera presnmass
Collaborator
|
Will need to add in docs for the new columns but will merge this for now to clear the backlog! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to update the behavior of COSMIC so that the supernova entry in the BPP (evol_type 15 or 16) reflects the state of the star prior to
assign_remnant.The current behavior is:
mass0 is not updated during the
evol_type == 15 / 16table entry.menv is not updated during the
evol_type == 15/ 16table entry.massc is updated sometimes, but does not reflect the core mass of the star immediately prior to supernovae.
The desired behavior is:
mass0 is updated to contain the preSN total mass of the star in all subsequent bpp entries, including the
evol_type == 15 / 16entry.massc is updated to contain the core mass of the star prior to supernova in the
evol_type == 15 / 16bpp entry.menv is updated to contain the quantity
mcbagb - mcfrom assign remnant during a Supernova explosionKatie and I looked a
hrdiag.fand determined that a Supernova of this kind can only occur whenmasscreflects a metallic core (not a Helium core). This enables us to print the metallic core mass of a star prior to Supernova, which is useful for updating supernova models, and comparing with other popsynth codes (specifically StarTrack).The meaning of
mcbagbis less clear, but can be interpreted as the Helium envelope, where the Hydrogen envelope can then be determined by calculatingmt - mc - mcbagb. This is usually, but not always, close to zero.We accomplish these objectives by introducing common block variables in
evolv2.f,assign_remnant.f, andcomenv.f, avoiding passing additional values tohrdiag.f, in order to avoid overhead inhrdiag.fwhich is called many times.