Singlesfix#705
Merged
Merged
Conversation
katiebreivik
commented
Jun 4, 2025
katiebreivik
commented
Collaborator
- Remove the extra return from the initial sampler to handle the single stars properly.
- Also cleaned up the warnings
…also removed warning for pickling objects since we only save them once and its not too much overhead
…rent numbers of singles for filtering in conv, this should work better and will save all the single data to the dat file as needed
Collaborator
Author
|
Hey @aliperego -- Can you check out the changes I made to see if this will still work with your |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (23.08%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #705 +/- ##
===========================================
- Coverage 86.91% 78.51% -8.40%
===========================================
Files 40 49 +9
Lines 25542 27118 +1576
Branches 0 843 +843
===========================================
- Hits 22198 21289 -909
- Misses 3344 5557 +2213
- Partials 0 272 +272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TristanBruel
added a commit
to TristanBruel/COSMIC
that referenced
this pull request
Jul 21, 2025
CPiyumal
pushed a commit
to CPiyumal/COSMIC
that referenced
this pull request
Oct 3, 2025
* removed passback on singles since we already have it with n_singles; also removed warning for pickling objects since we only save them once and its not too much overhead * removing the n singles return here as well * rigggghhhhttttt I forgot that if we specify kstars, then we get different numbers of singles for filtering in conv, this should work better and will save all the single data to the dat file as needed * fix warnings too * final updates and warnings * fixing secondary mass sampling to not allow both qmin and m2min * fix call to utils.pop_write and some warning messages * I think this is just a spacing diff * fixed this to set kstar_2 to 15 for singles * renaming write to initC * fix chained assignment * fix chained assignment but acutally dont break it * updating the build for python 3.11 and 3.12 * remove extra commented out text * add docs in for keep singlse * version bump * we dont want that commit hash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.