fixing the units for the central BH in CMC#710
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #710 +/- ##
===========================================
- Coverage 86.91% 78.35% -8.55%
===========================================
Files 40 49 +9
Lines 25542 27182 +1640
Branches 0 903 +903
===========================================
- Hits 22198 21298 -900
- Misses 3344 5611 +2267
- Partials 0 273 +273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix to the point-mass sampler too
Collaborator
|
merging this too @carlrodriguez ! |
CPiyumal
pushed a commit
to CPiyumal/COSMIC
that referenced
this pull request
Oct 3, 2025
* fixing the units for the central BH in CMC * Update cmc.py fix to the point-mass sampler too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to make sure the physical units in CMC are correct when including a central massive black hole. Currently the BH is included in the unit conversions to physical units even though the internal code units do not include it. This makes these consistent (both internal code units and physical units are only set by the cluster mass, not including the central BH).