Skip to content

Preserve zpars when calling Evolve.evolve for METISSE; add Tauris+2015 ECSN prescription#712

Closed
d-maclean wants to merge 10 commits into
COSMIC-PopSynth:METISSE-integratefrom
d-maclean:METISSE-ecsn
Closed

Preserve zpars when calling Evolve.evolve for METISSE; add Tauris+2015 ECSN prescription#712
d-maclean wants to merge 10 commits into
COSMIC-PopSynth:METISSE-integratefrom
d-maclean:METISSE-ecsn

Conversation

@d-maclean

Copy link
Copy Markdown
Contributor

Hello,

This PR has two parts. First, I modified zpars to be intent(in,out) in evolv2, allowing us to capture it when we call Evolve.evolve. This is necessary for METISSE, as zpars is not internally preserved after the first call, and it is also not recalculated. Now, we simply feed it back in to subsequent evolv2 calls, which should be fine as long as we don't allow changing metallicities mid-run.

Secondly, this adds the option to pass a negative number for ecsn. If this is done, mc is used to check for ECSN instead of mcbagb, allowing us to implement the Tauris+2015 ECSN prescription. You simply pass the negative of your max C/O core mass for ecsn.

@d-maclean
d-maclean marked this pull request as draft August 8, 2025 16:55
@d-maclean
d-maclean marked this pull request as ready for review August 8, 2025 16:58
@katiebreivik

Copy link
Copy Markdown
Collaborator

Hey @d-maclean -- I want to do my own double check to see if all ecsn values are accounted for, but in the meantime, can you add an error check for if the SSEDict has metisse specified, that there can only be one metallicity per evolve call? This should be in the big error check function in utils.

@d-maclean

Copy link
Copy Markdown
Contributor Author

@katiebreivik Done! I had to place this in Evolve.evolve, as the error_check doesn't have access to the initial binary table.

@d-maclean

Copy link
Copy Markdown
Contributor Author

There is a related PR recently merged in METISSE to force track reloading if zpars is all zeros. This is required if we call Evolve.evolve multiple times (like, in a jupyter notebook). I will push an update to the METISSE submodule to include that.

@d-maclean
d-maclean marked this pull request as draft August 12, 2025 19:47
@d-maclean d-maclean closed this Aug 27, 2025
@d-maclean

Copy link
Copy Markdown
Contributor Author

This PR is being split up. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants