Preserve zpars when calling Evolve.evolve for METISSE; add Tauris+2015 ECSN prescription#712
Closed
d-maclean wants to merge 10 commits into
Closed
Preserve zpars when calling Evolve.evolve for METISSE; add Tauris+2015 ECSN prescription#712d-maclean wants to merge 10 commits into
d-maclean wants to merge 10 commits into
Conversation
d-maclean
marked this pull request as draft
August 8, 2025 16:55
d-maclean
marked this pull request as ready for review
August 8, 2025 16:58
Collaborator
|
Hey @d-maclean -- I want to do my own double check to see if all |
Contributor
Author
|
@katiebreivik Done! I had to place this in Evolve.evolve, as the error_check doesn't have access to the initial binary table. |
Contributor
Author
|
There is a related PR recently merged in METISSE to force track reloading if |
d-maclean
marked this pull request as draft
August 12, 2025 19:47
Contributor
Author
|
This PR is being split up. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR has two parts. First, I modified
zparsto be intent(in,out) in evolv2, allowing us to capture it when we callEvolve.evolve. This is necessary for METISSE, aszparsis not internally preserved after the first call, and it is also not recalculated. Now, we simply feed it back in to subsequentevolv2calls, which should be fine as long as we don't allow changing metallicities mid-run.Secondly, this adds the option to pass a negative number for
ecsn. If this is done,mcis used to check for ECSN instead of mcbagb, allowing us to implement the Tauris+2015 ECSN prescription. You simply pass the negative of your max C/O core mass forecsn.