Skip to content

Added new kick prescriptions#790

Merged
katiebreivik merged 12 commits into
COSMIC-PopSynth:developfrom
astro-abhishek:add-new-kicks
Jul 8, 2026
Merged

Added new kick prescriptions#790
katiebreivik merged 12 commits into
COSMIC-PopSynth:developfrom
astro-abhishek:add-new-kicks

Conversation

@astro-abhishek

Copy link
Copy Markdown
Contributor

References for the kick prescriptions via abskickflag = 7 and abskickflag = 8:

[1] Neutron Star Kicks by the Gravitational Tug-boat Mechanism in Asymmetric Supernova Explosions: Progenitor and Explosion Dependence, Janka H.T., 2017, ApJ 837(1):84, arXiv:1611.07562 [astro-ph.HE].
-- Exact implementation matches Equation 2 from Chattaraj et al. 2026a.

[2] New constraints on the Bray conservation-of-momentum natal kick model from multiple distinct observations, Richards S. M., Eldridge J. J., Briel M. M., Stevance H. F., Willcox R., 2022, Published in: Mon.Not.Roy.Astron.Soc. 522 (2023) 3, 3972-3985.

@astro-abhishek

Copy link
Copy Markdown
Contributor Author

Here is a comparison of the existing natal kick prescriptions in COSMIC alongside the two new implementations introduced in this PR (kickflag 7 and 8).

Interestingly, Flags 1, 7, and 8 lead to similar looking distributions. If I understood correctly, Flag 1 (the standard COSMIC Maxwellian) gets its bimodal shape via hardcoded $\sigma$ values to differentiate between high velocity Fe core-collapse and low velocity ECSN/USSN.

In contrast, the "physics-based" formulations in Flags 7 and 8 appear to produce this bimodality naturally. This was the conclusion of my paper as well. And the idea behind this PR based on what we discussed at CCA last month.

natal_kick_distributions

@TomWagg
TomWagg self-requested a review June 23, 2026 21:16
@TomWagg TomWagg self-assigned this Jun 23, 2026
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.27%. Comparing base (8772c07) to head (8319a7b).
⚠️ Report is 176 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/src/kick.f 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #790       +/-   ##
============================================
- Coverage    86.91%   76.27%   -10.63%     
============================================
  Files           40       59       +19     
  Lines        25542    28122     +2580     
  Branches         0      985      +985     
============================================
- Hits         22198    21450      -748     
- Misses        3344     6367     +3023     
- Partials         0      305      +305     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katiebreivik katiebreivik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @astro-abhishek!!

Sorry for the delay on this!

@katiebreivik
katiebreivik merged commit 8aac0f2 into COSMIC-PopSynth:develop Jul 8, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants