5 new config. figures (pts, neta, hewind, zsun, and windflag)#808
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #808 +/- ##
============================================
- Coverage 86.91% 76.27% -10.64%
============================================
Files 40 59 +19
Lines 25542 28130 +2588
Branches 0 985 +985
============================================
- Hits 22198 21455 -743
- Misses 3344 6370 +3026
- Partials 0 305 +305 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
katiebreivik
left a comment
There was a problem hiding this comment.
Thanks for adding these @lukewilner! I have a few quick requests:
-
For zsun, we aren't sure that we need these figures since zsun shouldn't have a large range. Can you remove this file?
-
For windflag, can you add an additional panel that shows the same thing as the leftmost panel, but with the x/y axis on a log10 scale as an inset? An example is Figure 8 in this paper: https://iopscience.iop.org/article/10.3847/1538-4365/ac416c/pdf
-
For each figure, can you remove the title at the top in the small text?
Thank you!
katiebreivik
left a comment
There was a problem hiding this comment.
Thanks @lukewilner !
.py files for pts, neta, hewind, zsun, and windflag