Skip to content

5 new config. figures (pts, neta, hewind, zsun, and windflag)#808

Merged
katiebreivik merged 2 commits into
COSMIC-PopSynth:developfrom
lukewilner:luke-docs-upload
Jul 14, 2026
Merged

5 new config. figures (pts, neta, hewind, zsun, and windflag)#808
katiebreivik merged 2 commits into
COSMIC-PopSynth:developfrom
lukewilner:luke-docs-upload

Conversation

@lukewilner

Copy link
Copy Markdown
Contributor

.py files for pts, neta, hewind, zsun, and windflag

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.27%. Comparing base (8772c07) to head (5fb90e2).
⚠️ Report is 179 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #808       +/-   ##
============================================
- Coverage    86.91%   76.27%   -10.64%     
============================================
  Files           40       59       +19     
  Lines        25542    28130     +2588     
  Branches         0      985      +985     
============================================
- Hits         22198    21455      -743     
- Misses        3344     6370     +3026     
- Partials         0      305      +305     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katiebreivik
katiebreivik self-requested a review July 8, 2026 18:05

@katiebreivik katiebreivik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these @lukewilner! I have a few quick requests:

  1. For zsun, we aren't sure that we need these figures since zsun shouldn't have a large range. Can you remove this file?

  2. For windflag, can you add an additional panel that shows the same thing as the leftmost panel, but with the x/y axis on a log10 scale as an inset? An example is Figure 8 in this paper: https://iopscience.iop.org/article/10.3847/1538-4365/ac416c/pdf

  3. For each figure, can you remove the title at the top in the small text?

Thank you!

@katiebreivik katiebreivik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukewilner !

@katiebreivik
katiebreivik merged commit b3934ca into COSMIC-PopSynth:develop Jul 14, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants