fixed bugs cpp

C++/h1.cpp

@@ -3,7 +3,7 @@
 // ie. if the string given is 'djhfacdadcaop' the longest palindrom is 'acdadca' 
 // which should be the return value for the function longest pallindrome(char* s).
 
-#include<iostream>
+#include<bits/stdc++.h>//librar
 using namespace std;
 
 void printSubStr(
@@ -31,15 +31,15 @@ int longestPalSubstr(string str)
 		if (str[i] == str[i + 1]) {
 			table[i][i + 1] = true;
 			start = i;
-			maxLength = 2;
+			maxLength =2;
 		}
 	}
 
 	for (int k = 3; k <= n; ++k) {
-		for (int i = 0; i < n - k; ++i) {
+		for (int i = 0; i < n - k+1; ++i) {// n-k to n-k+1
 			int j = i + k - 1;
 
-			if (table[i + 1][j] && str[i] == str[j]) {
+			if (table[i + 1][j-1] && str[i] == str[j]) {//j-1
 				table[i][j] = true;
 
 				if (k > maxLength) {
@@ -61,7 +61,7 @@ int longestPalSubstr(string str)
 // Driver Code
 int main()
 {
-	string str = "forgeeksskeegfor";
+	string str = "forgeeksskeegrof";
 	cout << longestPalSubstr(str) << endl;
 	return 0;
 }

C++/h2.cpp

@@ -18,16 +18,19 @@ int count(int coins[], int n, int sum)
 	for (i = 1; i < sum + 1; i++) {
 		for (j = 0; j < n; j++) {
 
-			x = (i - coins[j] >= 0) ? table[j][i - coins[j]] : 1;
+			//x = (i - coins[j] >= 0) ? table[j][i - coins[j]] : 1;
+			x = (i - coins[j] >= 0) ? table[i - coins[j]][j]: 0;
+
 
 
-			y = (j > 1) ? table[j - 1][i] : 1;
+			//y = (j > 1) ? table[j - 1][i] : 1;
+			y = (j >= 1) ? table[i][j - 1] : 0;
 
 
 			table[i][j] = x + y;
 		}
 	}	
-	return table[sum-1][n - 1];							
+	return table[sum][n-1]; //table[sum-1][n - 1]; table[sum][n-1]						
 }
 
 // Driver Code

C++/m1.cpp

@@ -8,7 +8,7 @@ class Solution
 public:
     bool isPalindrome(string s)
     {
-        int i = 0, j = s.size();
+        int i = 0, j = s.size()-1;
 
         while (i < j)
         {
@@ -34,7 +34,7 @@ class Solution
             {
                 if (isPalindrome(s.substr(i, j)))
                 {
-                    if (result.size() < j)
+                    if (result.size() < s.substr(i,j).size())
                         result = s.substr(i, j + 1);
                 }
             }

C++/m2.cpp

@@ -15,7 +15,7 @@ class Solution {
         vector<vector<int>> output;
         for (int i = 0; i < nums.size(); i++){
             int j = i + 1;
-            int k = i+j;
+            int k = nums.size()-1;
             while (j < k) {
                 int sum = nums[i] + nums[j] + nums[k];
                 if (sum == target) {
@@ -28,8 +28,15 @@ class Solution {
                 }
             }
         }
-        for(auto triplets : s)
-            output.push_back(triplets);
-        return output;
+        for(auto triplets : s){
+            cout<<triplets[0]<<triplets[1]<<triplets[2];
+            output.push_back(triplets);}
+
     }
 };
+
+int main(){
+    vector<int>nums={1,2,-3,1,-2,1};
+    Solution s;
+    s.threeSum(nums);
+}

C++/m3.cpp

@@ -6,7 +6,8 @@ using namespace std;
 char *initialize() {
   char string[80];
 //   string = "hello"
-  char* ptr = string;
+  char* ptr ;
+  ptr = string;
   return ptr;
 }
 
@@ -16,8 +17,10 @@ void do_something_with(char* myval){
 
 main() {
 	cout << "enter value for myval" << endl;
-  char *myval = initialize();
+  char *myval ;
+  myval = initialize();
   cin >> *myval;
+  cout<<*myval;
   cout << "Variable intialized" << endl;
   do_something_with(myval);
 }

C++/m5.cpp

@@ -29,13 +29,13 @@ vector<int> spiralOrder(vector<vector<int> >& matrix)
 		int newX = x + dr[di];
 		int newY = y + dc[di];
 
-		if (0 <= newX || newX < m && 0 <= newY || newY < n
+		if (0 <= newX && newX < m && 0 <= newY && newY < n
 			&& !seen[newX][newY]) {
 			x = newX;
 			y = newY;
 		}
 		else {
-			di = (di + 1) / 4;
+			di = (di + 1) % 4;
 			x += dr[di];
 			y += dc[di];
 		}

C++/m6.cpp

@@ -4,7 +4,7 @@
 #include<string>
 
 int main(){
-    std :: string s = "Hello World";
+    std :: string s = NULL;
 
     for(int i=0;i < s.length(); i++){
         s[i] = toupper(s[i]);

C++/s1.cpp

@@ -6,7 +6,7 @@ using namespace std;
 int reverse(int x) {
     long r=0;                                  
     while(x){
-        r=r*10+x/10;
+        r=r*10+x%10;
         x=x/10;                                   
     }
     return r;

C++/s2.cpp

@@ -12,7 +12,7 @@ int main(){
     for(int i=0; i < myVec.size(); i++){
         std :: cout << myVec[i] << std :: endl;
     }
-    std :: cout << "Element at index 3: "<< myVec.at(3) << std::endl;
+    std :: cout << "Element at index 3: "<< myVec.at(2) << std::endl;
 
     return 0;
 }

C++/s3.cpp

@@ -18,7 +18,7 @@ void ineedj(void) {
 }
 
 main() {
-  int j;
+  //int j;
   j = foo(i);
   ineedj();
 }

C++/s4.cpp

@@ -4,16 +4,16 @@
 #include<iostream>
 #include <bits/stdc++.h>
 using namespace std;
-#define Random(n)  random()%n
+#define Random(n)  random(n)%n
 
-int random(){
+int random(int n){
     srand(time(0));
-    return rand();
+    return rand()%n;
 }
 
 
 int main(void){
-    int i=6, j=7;
+    int i=6, j=9;
     int val = Random(j-i+1);
 
     cout << val << endl;

C++/s6.cpp

@@ -1,10 +1,11 @@
 // to find the largest sum of subarray
 #include<iostream>
+#include<climits>
 using namespace std;
 
 int maxSubArraySum(int a[], int size)
 {
-    int max_so_far = INT_MIN, max_ending_here;
+    int max_so_far = 0, max_ending_here=0;
 
     for (int i = 0; i < size; i++) {
         max_ending_here = max_ending_here + a[i];
@@ -16,3 +17,8 @@ int maxSubArraySum(int a[], int size)
     }
     return max_so_far;
 }
+int main(){
+    int arr[]={-5,4,3,-2,1};
+    cout<<maxSubArraySum(arr,5);
+    return 0;
+}