Skip to content

Enhance model.set when destination is list#596

Merged
cuihantao merged 2 commits intoCURENT:developfrom
jinningwang:mdlset
Apr 8, 2025
Merged

Enhance model.set when destination is list#596
cuihantao merged 2 commits intoCURENT:developfrom
jinningwang:mdlset

Conversation

@jinningwang
Copy link
Copy Markdown
Contributor

No description provided.

@cuihantao
Copy link
Copy Markdown
Collaborator

Thanks Jinning. Can you fix the tests by the way?

@jinningwang
Copy link
Copy Markdown
Contributor Author

jinningwang commented Apr 5, 2025 via email

@jinningwang jinningwang requested a review from Copilot April 6, 2025 00:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • docs/source/release-notes.rst: Language not supported
Comments suppressed due to low confidence (1)

andes/core/model/model.py:515

  • Consider adding a validation check to ensure that the length of the uid list matches the length of the provided value list, to prevent potential index errors during assignment.
for i, u in enumerate(uid):

@cuihantao cuihantao merged commit 5e110ac into CURENT:develop Apr 8, 2025
3 checks passed
@jinningwang jinningwang deleted the mdlset branch April 24, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants