Enhance model.set when destination is list#596
Merged
cuihantao merged 2 commits intoCURENT:developfrom Apr 8, 2025
Merged
Conversation
Collaborator
|
Thanks Jinning. Can you fix the tests by the way? |
Contributor
Author
|
Sure, will do it later today
Regards,
Jinning
…On Sat, Apr 5, 2025 at 17:39 Hantao Cui ***@***.***> wrote:
Thanks Jinning. Can you fix the tests by the way?
—
Reply to this email directly, view it on GitHub
<#596 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS4OJPJNY3TL6QEWGSLD4L32YBERTAVCNFSM6AAAAAB2Q5JIRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRGEYDGNJVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: cuihantao]*cuihantao* left a comment (CURENT/andes#596)
<#596 (comment)>
Thanks Jinning. Can you fix the tests by the way?
—
Reply to this email directly, view it on GitHub
<#596 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS4OJPJNY3TL6QEWGSLD4L32YBERTAVCNFSM6AAAAAB2Q5JIRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRGEYDGNJVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- docs/source/release-notes.rst: Language not supported
Comments suppressed due to low confidence (1)
andes/core/model/model.py:515
- Consider adding a validation check to ensure that the length of the uid list matches the length of the provided value list, to prevent potential index errors during assignment.
for i, u in enumerate(uid):
cuihantao
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.