[PD1-915] Upgrade eslint 10, jest 30 to fix all Dependabot security alerts#10
[PD1-915] Upgrade eslint 10, jest 30 to fix all Dependabot security alerts#10joshuanapoli wants to merge 2 commits intomainfrom
Conversation
- Upgrade eslint 9→10 (fixes minimatch ReDoS vulnerability, alert #23) - Upgrade jest 29→30 (fixes glob command injection vulnerability, alert #7) - Replace ts-jest with @swc/jest (ts-jest has no jest 30 support) - Add resolutions for js-yaml ^4.1.0 (fixes prototype pollution, alert #6) and test-exclude ^8.0.0 (eliminates remaining minimatch 3.x and glob 7.x) - Upgrade typescript-eslint to 8.57 for eslint 10 compatibility Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the project's security posture and development efficiency by resolving all open Dependabot security alerts. It achieves this through significant dependency upgrades for ESLint and Jest, alongside a strategic switch from Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Main merged the minimatch 3.1.2→3.1.5 bump (PR #9), which conflicts with our branch that removes minimatch 3.x entirely. Resolved by regenerating yarn.lock and .pnp.cjs with our upgrades applied. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request effectively addresses several security vulnerabilities by upgrading eslint and jest. The migration from ts-jest to @swc/jest is a necessary change for Jest 30 compatibility. My review focuses on ensuring the new configuration is maintainable and all dependency versions are compatible. I've identified a critical version incompatibility with typescript-eslint that needs to be addressed, and a minor maintainability improvement for the new Jest configuration.
Summary
Security Fixes
Test plan
🤖 Generated with Claude Code