And local queue/sendmail as transport - #55
Open
krono wants to merge 1 commit into
Open
Conversation
e3rd
requested changes
Aug 4, 2026
e3rd
left a comment
e3rd
left a comment
Member
There was a problem hiding this comment.
Fill in CHANGELOG, add something to README, increase the version to pyproject.toml and I'll release :)
| print(str(res)) | ||
| sys.exit(0) | ||
| elif res: | ||
| elif res or (args["send"] and not(args["encrypt"] or args["sign"])): |
Member
There was a problem hiding this comment.
Why having this line, for what usecase?
Contributor
Author
There was a problem hiding this comment.
I'm on vacation, I can look into my work fork 2 weeks or so, please stand by
krono
commented
Aug 4, 2026
| """ | ||
| self._sendmail = SENDMAIL_PATH if self._sendmail == True else str(self._sendmail) | ||
| _unused = to_addrs | ||
| args = ["/usr/sbin/sendmail", "-t", "-oi", "-f", from_addr] |
Contributor
Author
There was a problem hiding this comment.
I jsut see that I fogot to acutally use self._sendmail here. will fix eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54