Fix play-by-play special teams and LCB output - #48
Closed
tpitzel wants to merge 1 commit into
Closed
Conversation
CalebRose
approved these changes
Jul 20, 2026
CalebRose
left a comment
Owner
There was a problem hiding this comment.
Approved. Just to confirm, does the build successfully run locally?
Contributor
Author
Yes, that's why I was confused that punt returns still were off in this past weekends games because they look right locally. Then I had codex discover that change wasn't in master and fired this pull request off |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ResultYardsvalue directly when narrating punt and kickoff returns in both result and stream output.Fcbparticipant field intoLcb, returnLcbfrom play-by-play responses, and export the LCB value in NFL play-by-play CSVs.IsRightfield mapping and a right-miss field-goal narration string.Why
The engine already supplies return distance directly through
ResultYards, but the API was reconstructing return yardage from field-position coordinates. That produced narration which disagreed with the numeric play result and ensuing field position. The cornerback participant also existed under bothFcbandLcb, while the export path continued reading the legacy name.Impact
New and historical play-by-play responses generated from stored direct-return-yard data will report punt and kickoff returns consistently. LCB participant IDs will also be exposed under the expected field without breaking records that still contain the legacy
Fcbvalue.Checks
go test ./...git diff --check upstream/master...HEAD