Skip to content

COO-175 Updates to detector config structure, more support for full focal plane image creation and new DEIMOS detector config#5

Open
Yashvi-Sharma wants to merge 3 commits into
mainfrom
COO-175_detconfigs
Open

COO-175 Updates to detector config structure, more support for full focal plane image creation and new DEIMOS detector config#5
Yashvi-Sharma wants to merge 3 commits into
mainfrom
COO-175_detconfigs

Conversation

@Yashvi-Sharma
Copy link
Copy Markdown
Collaborator

Major changes:

  • Modified detector config focal plane params to handle flipping and rotating, updated FocalPlaneImage accordingly
  • Added new DEIMOS science detector config (final format, 8 FITS files one per detector)
  • Updated archon output DEIMOS config (one file, all detectors in one extension)
  • Added better logic to slice constructors to handle more cases
  • Added custom file loader for DEIMOS

Housekeeping changes:

  • Cleaned up imports
  • Cleaned up comments in example YAMLs and docstrings

…. Minor fixes in slice handling. Updated example configs.
…added rotate and flip support in FocalPlaneImage,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term thinking - but most likely we'll need another location for these configurations that are specific to projects. Not sure if having it in the main repo that everyone has to checkout is good

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agree. The configs are not required to be in there by default, people can load them from any local path. The ones in there currently are for examples and demos. Eventually if people want to store a template config for instruments to make it available to everyone, it can live in there.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests outside of the notebooks?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have written some but not committed them yet, will do that next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants