COO-175 Updates to detector config structure, more support for full focal plane image creation and new DEIMOS detector config#5
Conversation
…. Minor fixes in slice handling. Updated example configs.
…added rotate and flip support in FocalPlaneImage,
There was a problem hiding this comment.
Long term thinking - but most likely we'll need another location for these configurations that are specific to projects. Not sure if having it in the main repo that everyone has to checkout is good
There was a problem hiding this comment.
Yes agree. The configs are not required to be in there by default, people can load them from any local path. The ones in there currently are for examples and demos. Eventually if people want to store a template config for instruments to make it available to everyone, it can live in there.
There was a problem hiding this comment.
Are there tests outside of the notebooks?
There was a problem hiding this comment.
Yes, I have written some but not committed them yet, will do that next
Major changes:
Housekeeping changes: