fix: migrate Phase-1 live check off tabbed Notepad onto mspaint (#20) - #41
Merged
Merged
Conversation
Current Windows 11 notepad.exe is single-process tabbed, so PID-scoped ownership can no longer launch-and-own it and the fixture fails safe (AppSessionError) rather than attach to a window it can't prove is ours. Replace tests/test_notepad_live.py with tests/test_mspaint_live.py, targeting mspaint.exe (already the live target elsewhere in the suite) and preserving the same discipline: act->verify round trip, re-assert after actions, right-window-among-several, and a structurally-asserted save-prompt dismissed cleanly. Every assertion is grounded in mspaint's real accessibility tree, captured live on Windows 11 while writing the check (toggle-button checked/pressed states, the canvas-click that actually dirties the document, the curly-apostrophe "Don't save" label). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
CameronCrow
force-pushed
the
fix/20-migrate-live-check-notepad-to-mspaint
branch
from
July 23, 2026 15:27
ca86752 to
6be83cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Summary
tests/test_notepad_live.pywithtests/test_mspaint_live.py. Current Windows 11notepad.exeis the single-process tabbed Notepad, so PID-scoped ownership (Phase 2A: PID-scoped window ownership #12) cannot launch-and-own it —app_session/ui.window(pid=...)fails safe there rather than risk attaching to one of Cameron's real open tabs.test_app_session.py,test_acceptance_phase2.py), so this makes the Phase-1 mechanism proof ownable again on current Win11.checked,pressedstates — the exact vocabularyui.py's own docstring already cites as the original smoke-test finding — and a canvas click, which is what actually dirties a Paint document).test_app_session.pythat pointed attest_notepad_liveand mis-described its own live test as launching Notepad (it already launches mspaint).planning/TODO.md's Phase-1 line andplanning/PLAN_MAIN.md's Phase-3 status note to reflect the migration — no other phase lines touched.Test plan
python -m pytest -q— 233 passed, 6 deselected (thelivetests, as expected without-m live)python -m pytest tests/test_mspaint_live.py -m live -v— all 4 tests passed against a real Windows 11 desktop, run twice for stability, no straymspaint.exeprocess or window left behind either time🤖 Generated with Claude Code