Various UX improvements - #11
Open
trvv wants to merge 2 commits into
Open
Conversation
- Alphabetical building sorts - Toggleable button informations - Rerouted data filling mechanics into JS file instead of current inline script tags
- Now requests updated version of campusepulse buildings - Falls back to local version if that request fails - Updated version of buildings.json to match campuspulse
Collaborator
|
So it looks like you reformatted a lot of the files that you touched - which makes the Diff really messy and hard to read. can you set the formatting back so that its easier to see what was actually changed? |
MoralCode
reviewed
Nov 1, 2025
Comment on lines
-53
to
+117
| <!-- hidden form items --> | ||
| {% for item in page.staticvalues %} | ||
| <input type="hidden" name="{{ item.name }}" value="{{ item.value }}"> | ||
| {% endfor %} | ||
| <!-- TODO: submit building name too --> | ||
| {% include form_end.html destination=page.destination %} | ||
| <label for="floor">Floor</label> | ||
| <input | ||
| type="text" | ||
| id="floor" | ||
| name="floor" | ||
| required | ||
| placeholder="Enter the floor (e.g., A for Basement, 1, 2, etc.)" | ||
| pattern="A|B|[0-9]" | ||
| title="Enter floor number as either 'A', 'B', or a single numeric value" |
Collaborator
There was a problem hiding this comment.
it also looks like you removed jekyll templating here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does clobber the new (building) data import functionality. It should be a simple reimplementation in data-filler.js instead of doing it on each file, though.