Fix cancel button functionality for Android 14+ - #21
Draft
codegen-sh[bot] wants to merge 1 commit into
Draft
Conversation
- Changed RECEIVER_EXPORTED back to RECEIVER_NOT_EXPORTED for internal app communication - Added setPackage() to PendingIntent to make it explicit and ensure proper delivery - Simplified broadcast receiver validation logic This fixes the issue where the cancel button in notifications was not working on newer Android versions due to stricter broadcast receiver requirements.
CanYumusak
self-requested a review
August 6, 2025 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The cancel button in transfer notifications was not working on Android 14+ devices. This was due to changes in Android's broadcast receiver requirements that became mandatory starting with API level 34.
Root Cause
RECEIVER_EXPORTEDwhen it should useRECEIVER_NOT_EXPORTEDfor internal app communicationSolution
RECEIVER_EXPORTEDback toRECEIVER_NOT_EXPORTEDsince this is internal app communication that shouldn't receive broadcasts from external appssetPackage(context.packageName)to the PendingIntent creation to make it explicit and ensure proper deliveryTesting
This fix addresses the Android 14+ broadcast receiver requirements while maintaining backward compatibility. The cancel functionality should now work properly across all supported Android versions.
Files Changed
Android/app/src/main/java/de/canyumusak/androiddrop/TransferService.ktFixes the issue where users couldn't cancel file transfers from the notification on newer Android devices.
💻 View my work • About Codegen