fix: XML-entity-decode sitemap <loc> URLs (#50)#51
Merged
Conversation
Spec-compliant sitemaps escape `&` in `<loc>` URLs as `&` per sitemaps.org. parseSitemapXml passed the literal `...&...` to the fetcher, which the origin treats as a different (usually empty) request. On a sitemap index — where every child <loc> carries query params (BigCommerce, paginated CMS sitemaps) — every child fetch failed and the audit aborted with "No auditable URLs found in sitemap."; flat <urlset> pages were silently dropped. Both the urlset and sitemapindex branches now decode the five predefined XML entities plus decimal/hex numeric character references (& last, out-of-range refs left untouched so a malformed sitemap can't throw). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50. Spec-compliant sitemaps escape
&in<loc>URLs as&(per sitemaps.org), butparseSitemapXmlpassed the literal...&...to the fetcher, which the origin treats as a different (usually empty) request — so a sitemap index (every child<loc>carries query params, e.g. BigCommerce) aborted withNo auditable URLs found in sitemap., and flat<urlset>pages were silently dropped. Both theurlsetandsitemapindexbranches now decode the five predefined XML entities plus decimal/hex numeric character references (&resolved last; out-of-range refs left untouched so a malformed sitemap can't throw), with no API or scoring change. Adds 4 unit tests (urlset query params, the sitemap-index repro, and numeric/hex/ampersand-last ordering) and bumps the version to 4.0.1 with a CHANGELOG entry. Full suite: 363/363 pass, typecheck and lint clean.🤖 Generated with Claude Code