Skip to content

fix(ci): isolate visual diff captures#2710

Open
riderx wants to merge 1 commit into
mainfrom
codex/fix-visual-diff-timeouts
Open

fix(ci): isolate visual diff captures#2710
riderx wants to merge 1 commit into
mainfrom
codex/fix-visual-diff-timeouts

Conversation

@riderx

@riderx riderx commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Run each visual-diff route in an isolated child process with a two-minute watchdog.
  • Preserve the head runner and route configuration while the pipeline checks out the base revision.
  • Bound only the capture step to 15 minutes, leaving report upload and comment steps available.

Validation

  • Bundled 1 module in 6ms

    visual-diff.js 28.38 KB (entry point)

  • Checking formatting...
    All matched files use Prettier code style!

  • (expected route-validation failure)

Review in cubic


Note

Low Risk
Changes are limited to CI visual-diff scripting, workflow timeouts, and generated DB types; no production app or auth logic is modified.

Overview
Refactors the visual diff pipeline so each route screenshot runs in its own child process with a 2-minute watchdog, instead of reusing one browser across all routes in a phase.

The capture-route CLI command captures a single route; the parent still starts the shared backend/frontend stack once per phase, then spawns isolated captures. VISUAL_DIFF_CONFIG_PATH lets children load a bundled config snapshot. On run, the head route manifest and runner are bundled to .mjs files before git checkouts so base/after captures still use the PR’s route list and capture logic.

The visual diff workflow step gets a 15-minute timeout on the capture pipeline only (artifact upload and PR comment steps stay outside that bound).

Also syncs generated Supabase types with created_by_apikey_rbac_id on app_versions (unrelated to the CI script behavior).

Reviewed by Cursor Bugbot for commit 7247e2a. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bb046439-9ca3-4a6f-b9a8-e9b27e1308cc

📥 Commits

Reviewing files that changed from the base of the PR and between 9094ea7 and 7247e2a.

📒 Files selected for processing (4)
  • .github/workflows/visual-diff.yml
  • scripts/visual-diff.ts
  • src/types/supabase.types.ts
  • supabase/functions/_backend/utils/supabase.types.ts

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing codex/fix-visual-diff-timeouts (7247e2a) with main (8912567)2

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (9094ea7) during the generation of this report, so 8912567 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@riderx
riderx force-pushed the codex/fix-visual-diff-timeouts branch from 28c1a49 to eaf8b35 Compare July 17, 2026 09:26
@riderx
riderx marked this pull request as ready for review July 17, 2026 09:38
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_be0d7890-379b-4714-8aed-0337c18291a8)

@cursor
cursor Bot requested a review from WcaleNieWolny July 17, 2026 09:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Cursor Bugbot skipped due to a usage limit, so automated review is incomplete. The visual-diff subprocess refactor is non-trivial CI logic and needs human review before merge.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver External

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Confidence score: 5/5

  • Safe to merge after the addressed issues were fixed.

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/types/supabase.types.ts
Comment thread scripts/visual-diff.ts Outdated
Comment thread scripts/visual-diff.ts Outdated
Comment thread scripts/visual-diff.ts Outdated
@riderx
riderx force-pushed the codex/fix-visual-diff-timeouts branch from eaf8b35 to 7247e2a Compare July 17, 2026 09:52
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_a4d1c59a-00bd-41b2-af00-0ca8ef9c374a)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Not approving: Cursor Bugbot completed as skipped (usage limit reached), so automated review is incomplete. Human review is still required; WcaleNieWolny is already assigned as reviewer.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Cursor Bugbot skipped (usage limit), so automated review is incomplete. The visual-diff subprocess refactor and supabase type changes exceed the low-risk approval threshold. WcaleNieWolny is already assigned for human review.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver External

@sonarqubecloud

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limits), so I am not approving automatically. Human review is still needed; WcaleNieWolny is already requested as a reviewer.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant