fix(ci): required checks must always report (#53 follow-up) - #55
Merged
Merged
Conversation
The leaf lane added in #53 made the twelve heavy jobs *skip* on a leaf change, assuming a skipped job satisfies a required check. A ruleset does not treat a skipped job as satisfied, so #54 (a leaf-only PR) came back BLOCKED even though `changes` and `leaf` passed. Fix: the five required jobs (`lint`, `test (3.12)`, `core-boundary`, `published-surfaces`, `packaging-guards`) now always run; only the seven non-required heavy jobs (`test-deploy`, `hub`, `extras`, `blocked-deps`, `docs`, `client`, `headless`) skip on a leaf change. `test` keeps `needs: changes` and narrows its matrix to `3.12` when leaf, so the required `test (3.12)` still reports while three cells are cut. The `leaf` job stays as a fast extra signal; it is not a required check (the ruleset was reverted to its original five). Refs Capsize-Games/hq#14
Member
Author
§12.7 clause 8 record — temporary ruleset mutation to unblock this merge(a) Owner approval: covered by the owner's standing approval for this wave on hq#14 ("apply §12.7 clause 8 in full") — recorded here as required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #53. Platform finding: a ruleset does not treat a skipped job as a satisfied required check — leaf-only PR #54 came back
BLOCKEDwithchangesandleafgreen and the twelve heavy jobsskipping.Fix
lint,test (3.12),core-boundary,published-surfaces,packaging-guards) now always run.test-deploy,hub,extras,blocked-deps,docs,client,headless) skip on a leaf change.testkeepsneeds: changesand narrows its matrix to3.12when leaf, so the requiredtest (3.12)still reports while three cells are cut.leafjob remains a fast extra signal; it is not required (ruleset reverted to its original five — verifiedbypass_actors: [],enforcement: active).Why this shape
Per-path required checks are not expressible in a ruleset, so a fast lane cannot replace the required checks; it can only remove work that is not itself required. This keeps the gate honest (every required check still reports a real result) and still cuts 7 jobs plus 3 test cells on a leaf change.
Verification
if:; the seven non-required jobs keep the gate.Refs Capsize-Games/hq#14