Fix crash on multipart body referencing a schema without properties#467
Merged
Carapacik merged 1 commit intoJun 21, 2026
Merged
Conversation
Carapacik
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #466
swagger_parsercrashes (aborting the whole generation) when an endpoint declares amultipart/form-datarequest body that references (via\$ref) an object schema without apropertiesfield.type 'Null' is not a subtype of type 'Map<String, dynamic>' in type castatOpenApiParser.parseRestClients.parametersV3.Root cause
The multipart
\$refbranch assumes the referenced schema always hasproperties, while the inline (non-\$ref) branch already tolerates a missingpropertiesmap (properties = {}). This makes the\$refbranch consistent with the inline one.Reproducer (real-world)
An ASP.NET Core / FastEndpoints file-import endpoint whose request DTO is an empty placeholder while the file is read from the stream emits a multipart body referencing an empty object schema (
{ "type": "object" }), e.g.POST /api/admin/team-schedule/import→EmptyRequest. Today this wipes the entire generated client becausemake genremoveslib/srcfirst andswagger_parserexits0despite the error.Changes
open_api_parser.dart: null-guardpropertiesin the multipart\$refbranch (treat as empty form, like the inline branch).multipart_request_with_ref_no_properties.Checklist
dart format .dart analyze— no issuesdart test— all tests pass (423 passed, 2 pre-existing skips)