Fix crash related to AppDelegate#156
Merged
mmertsock merged 2 commits intoCEVRelease-2.xfrom Oct 9, 2025
Merged
Conversation
eschramm
approved these changes
Oct 9, 2025
eschramm
left a comment
eschramm
left a comment
There was a problem hiding this comment.
LGTM - yikes, this makes me wonder how much we should be monitoring the main fork. It's frustrating that they make most of their updates in monster PRs with no documentation so it's hard to know what we should take.
Member
Author
|
(To clarify, this was only causing crashes in the refactor branch of our app. So, no impact in production for us) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several lines of ResearchKit v2 code get a UIWindow instance via the AppDelegate instance. This causes a crash in apps with a newer UIScene/SwiftUI lifecycle: the
[UIApplicationDelegate window]selector is not guaranteed to exist.Pulled in some recent updates to the main ResearchKit fork to implement this fix.
Testing
Launch basically any ResearchKit v2 survey, and ensure the app does not immediately crash.