Conversation
We compute the data we acquired from Arduino to decide on what path the robot should take.
EduardoSantos7
requested changes
Apr 1, 2021
Collaborator
EduardoSantos7
left a comment
EduardoSantos7
left a comment
There was a problem hiding this comment.
Muy limpio el código! Solo el detalle de que está mal nombrado el archivo y posibles mejoras.
|
|
||
| else: | ||
| ser.write('b'.encode()) | ||
|
|
Collaborator
There was a problem hiding this comment.
Puedes borrar todas las lineas demás
| @@ -0,0 +1,80 @@ | |||
| from abc import ABC, abstractmethod | |||
Collaborator
There was a problem hiding this comment.
Por qué usaste la clase ABC en lugar de lanzar un error por falta de implementación?
| @@ -0,0 +1,80 @@ | |||
| from abc import ABC, abstractmethod | |||
| import serial | |||
Collaborator
There was a problem hiding this comment.
el orden de los imports no es el adecuados según PEP8
| from abc import ABC, abstractmethod | ||
| import serial | ||
|
|
||
| ser = serial.Serial('COM3', 9600) |
Collaborator
There was a problem hiding this comment.
Sería útil implementar un especie de driver para manejar comunicaciones seriales?
| self.VCC = VCC | ||
|
|
||
| @abstractmethod | ||
| def send_parameter(parameter): |
Collaborator
There was a problem hiding this comment.
Podrías agregar tipado como def send_parameter(parameter: str) -> None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We compute the data we acquired from Arduino to decide on what path the robot should take.