-
Notifications
You must be signed in to change notification settings - Fork 7
Get our regression tests running regularly via a GitHub workflow. #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,24 +104,6 @@ jobs: | |
| # for OpenSSL support | ||
| apt-get install -y libssl-dev | ||
|
|
||
| # for integration/regression test | ||
| apt-get install -y \ | ||
| libcompress-raw-zlib-perl \ | ||
| libdata-dumper-simple-perl \ | ||
| libdatetime-perl \ | ||
| libfile-copy-recursive-perl \ | ||
| libfile-path-tiny-perl \ | ||
| libfile-spec-native-perl \ | ||
| libnet-inet6glue-perl \ | ||
| libnet-ssh2-perl \ | ||
| libnet-ssleay-perl \ | ||
| libnet-telnet-perl \ | ||
| libposix-2008-perl \ | ||
| libtest-unit-perl \ | ||
| libtime-hr-perl \ | ||
| libwww-perl | ||
| PERL_MM_USE_DEFAULT=1 perl -MCPAN -e 'install Net::FTPSSL' | ||
|
|
||
| # for test code coverage | ||
| apt-get install -y lcov ruby | ||
| gem install coveralls-lcov | ||
|
|
@@ -160,15 +142,6 @@ jobs: | |
| cd proftpd | ||
| make install | ||
|
|
||
| - name: Run integration tests | ||
| if: ${{ matrix.compiler == 'gcc' && matrix.container == 'ubuntu:22.04' }} | ||
| env: | ||
| PROFTPD_TEST_BIN: /usr/local/sbin/proftpd | ||
| PROFTPD_TEST_DIR: ${{ github.workspace }}/proftpd | ||
| run: | | ||
| cd proftpd/contrib/mod_vroot | ||
| perl tests.pl | ||
|
|
||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think having a separate workflow for running regression tests makes them more visible, hence this breaking out of this step. |
||
| - name: Build as shared module | ||
| env: | ||
| CC: ${{ matrix.compiler }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| name: Regression Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| paths-ignore: | ||
| - '*.html' | ||
| - '*.md' | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| env: | ||
| # Let's try opting into use of Nodejs v24; see: | ||
| # https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ | ||
| # GitHub runners still causing problems with NodeJS v20; see: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||
|
|
||
| DEBIAN_FRONTEND: noninteractive | ||
| TZ: America/Los_Angeles | ||
|
|
||
| strategy: | ||
| matrix: | ||
| compiler: | ||
| - gcc | ||
| container: | ||
| - ubuntu:22.04 | ||
|
|
||
| container: ${{ matrix.container }} | ||
|
|
||
| steps: | ||
| - name: Checkout ProFTPD | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| repository: proftpd/proftpd | ||
| path: proftpd | ||
|
|
||
| - name: Checkout module source code | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| path: proftpd/contrib/mod_vroot | ||
|
|
||
| - name: Install Ubuntu packages | ||
| run: | | ||
| apt-get update -qq | ||
| # for builds | ||
| apt-get install -y gcc git make tzdata | ||
|
|
||
| # for OpenSSL support | ||
| apt-get install -y libssl-dev | ||
|
|
||
| # for integration/regression tests | ||
| apt-get install -y \ | ||
| libauthen-oath-perl \ | ||
| libcompress-raw-zlib-perl \ | ||
| libdata-dumper-simple-perl \ | ||
| libdatetime-perl \ | ||
| libfile-copy-recursive-perl \ | ||
| libfile-path-tiny-perl \ | ||
| libfile-spec-native-perl \ | ||
| libmime-base32-perl \ | ||
| libnet-address-ip-local-perl \ | ||
| libnet-inet6glue-perl \ | ||
| libnet-ssh2-perl \ | ||
| libnet-ssleay-perl \ | ||
| libnet-telnet-perl \ | ||
| libposix-2008-perl \ | ||
| libtest-unit-perl \ | ||
| libtime-hr-perl \ | ||
| libwww-perl | ||
| PERL_MM_USE_DEFAULT=1 perl -MCPAN -e 'install Net::FTPSSL' | ||
|
|
||
| # for debugging | ||
| gcc --version | ||
| openssl version -a | ||
|
|
||
| - name: Install with static modules | ||
| # NOTE: Docker does not have good IPv6 support, hence we disable it. | ||
| run: | | ||
| cd proftpd | ||
| ./configure --enable-ctrls --disable-ipv6 --with-modules=mod_sftp:mod_vroot | ||
| make | ||
| ./proftpd -V | ||
| make install | ||
|
|
||
| - name: Run integration tests | ||
| env: | ||
| PROFTPD_TEST_BIN: /usr/local/sbin/proftpd | ||
| PROFTPD_TEST_CI: github | ||
| PROFTPD_TEST_DIR: ${{ github.workspace }}/proftpd/tests | ||
| run: | | ||
| cd proftpd/contrib/mod_vroot | ||
| perl tests.pl |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now with regression/integration tests running in a separate workflow, we don't need to install these packages for the CI workflow. Nifty.