Skip to content

[python] Remove pattern matching operators to be compatible with older python versions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent-botbol merged 1 commit into from
May 14, 2025
Merged

[python] Remove pattern matching operators to be compatible with older python versions #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dates_calc.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ depends: [
"ocaml" {>= "4.11.0"}
"alcotest" {with-test & >= "1.0.0"}
"qcheck" {with-test & >= "0.10"}
# "conf-python" {with-test}, actually, python>=3.12 is needed for the tests. Cf. https://github.com/ocaml/opam-repository/pull/26738
"conf-python-3" {with-test}
"conf-openjdk" {with-test}
"odoc" {with-doc}
]
Expand Down
20 changes: 9 additions & 11 deletions lib_python/src/dates_calc/dates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,12 @@ def is_leap_year(year : int) -> bool:
return (year % 400 == 0) or (year % 4 == 0 and year % 100 != 0)

def days_in_month(*, month : int, is_leap_year : bool) -> int:
match month:
case 1 | 3 | 5 | 7 | 8 | 10 | 12: return 31
case 4 | 6 | 9 | 11: return 30
case 2:
return 29 if is_leap_year else 28
case _:
raise InvalidDate
if month in [1, 3, 5, 7, 8, 10, 12]: return 31
elif month in [4, 6, 9, 11]: return 30
elif month == 2:
return 29 if is_leap_year else 28
else:
raise InvalidDate

def add_months_to_first_of_month_date(*, year : int, month : int, months : int) -> tuple[int, int]:
"""
Expand Down Expand Up @@ -139,10 +138,9 @@ def last_day_of_month(self) -> Date:
def round(self, round : DateRounding) -> Date:
if self.is_valid: return self
else:
match round:
case DateRounding.AbortOnRound: raise AmbiguousComputation
case DateRounding.RoundDown: return self.prev_valid_date()
case DateRounding.RoundUp: return self.next_valid_date()
if round == DateRounding.AbortOnRound: raise AmbiguousComputation
elif round == DateRounding.RoundDown: return self.prev_valid_date()
elif round == DateRounding.RoundUp: return self.next_valid_date()

# This function is only ever called from `add_dates` below.
# Hence, any call to `add_dates_years` will be followed by a call
Expand Down