Repository navigation
feat: make capture_ids optional with 96-well-plate auto-generation - #1
Merged
Merged
Conversation
- Add utils.py with shared generate_wellplate_ids() helper - shape2xml_v2.py: capture_ids defaults to None, auto-generates well-plate IDs - shape2csv_v2.py: add capture_ids parameter, output '# Group: <cap_id>' instead of bare '#' - main.py: --cap_ids optional for both csv and xml formats - Add CI workflow: docker-build-pr.yml builds image on PR (no push)
thomas-enzlein
force-pushed
the
feat/optional-capids-wellplate
branch
from
June 10, 2026 10:57
b471584 to
4a92009
Compare
…dency - Remove libgl1 and libglib2.0-0 — opencv-python-headless doesn't need them - 674 MB → 372 MB (302 MB / 45% reduction)
When --cap_ids is omitted, generate one ID per unique label (not per segment) and expand via label mapping — consistent with manual --cap_ids behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
--cap_idsoptional for both csv and xml formats. When omitted, capture IDs are auto-generated using 96-well-plate naming (A1, B1, ..., H12, A13, ...).Changes
utils.py(new)generate_wellplate_ids(n)— generates well-plate-style IDs, used by both CSV and XML modulesshape2xml_v2.pycapture_idsparameter now defaults toNoneNone: auto-generates well-plate IDs viagenerate_wellplate_ids()_generate_wellplate_idsremoved in favor of shared utilityshape2csv_v2.pycapture_idsparameter (defaultNone)#to# Group: <cap_id>capture_idsisNoneaddshape2csv()main.pycapture_ids=mapped_cap_ids--cap_idshelp text updated to reflect optional nature.github/workflows/docker-build-pr.yml(new)masterTesting
docker build -t shape2instrument:test . && docker run --rm shape2instrument:test --helpCloses: # (issue if applicable)