Skip to content

Ensure resources are released after yielding devices and sample posit… #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idocx merged 2 commits into from
Dec 21, 2025
Merged

Ensure resources are released after yielding devices and sample posit… #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f33ab3
Ensure resources are released after yielding devices and sample posit…
idocx Dec 21, 2025
f00a38f
fix linting
idocx Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion alab_management/dashboard/routes/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def query_experiment_results(exp_id: str):
if experiment is None:
return {"status": "error", "errors": "Cannot find experiment with this exp id"}

progress, error_state = get_experiment_progress(exp_id)
progress, _ = get_experiment_progress(exp_id)

return_dict = {
"id": str(experiment["_id"]),
Expand Down
7 changes: 4 additions & 3 deletions alab_management/lab_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,10 @@ def request_resources(
for device_type, device_name in devices.items()
} # type: ignore
self._task_view.update_status(task_id=self.task_id, status=TaskStatus.RUNNING)
yield devices, sample_positions

self._resource_requester.release_resources(request_id=request_id)
try:
yield devices, sample_positions
finally:
self._resource_requester.release_resources(request_id=request_id)

def _sample_name_to_id(self, sample_name: str) -> ObjectId:
"""
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ select = [
"W", # pycodestyle
"YTT", # flake8-2020
]
ignore = ["B028", "PLW0603", "RUF013", "D100", "D404", "D401", "D205", "RUF100"]
ignore = ["B028", "PLW0603", "RUF013", "D100", "D404", "D401", "D205", "RUF100", "RUF059"]
pydocstyle.convention = "numpy"

[tool.ruff.lint.per-file-ignores]
Expand Down