fix: skip log viewer for partner app deploys - #74
Merged
Conversation
Partner services don't emit build logs, so creating the streaming log viewer just produced a misleading "Waiting for logs..." message and opened an unused websocket. Build status polling already drives the state on its own. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
For partner deploys the app isn't ready when the build is accepted — say "Build pending (ID: ...)" instead of "Created app (Build ID: ...)". Standard flow wording is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Hkhan161
approved these changes
Aug 11, 2026
The appCreatedMsg partner branch had no live coverage: the only test over it put its Msg in Finally(), which the harness never dispatches (Finally only intercepts messages produced by a previous Step), so the subtest never ran. Turn it into a real Step and add three partner cases: - interactive: no log viewer is built and the view never shows the "Waiting for logs..." block - simple output: prints the build-pending line and returns the status poll, which is the only thing driving the build to a terminal state - detach: exits instead of polling Each case asserts against a strict websocket mock, so re-introducing the streaming viewer for partner deploys fails the test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 12, 2026
jonoirwinrsa
added a commit
that referenced
this pull request
Aug 12, 2026
## Problem Partner service deploys skip file loading, zipping and upload entirely — no local file is ever packaged. Validation demanded `main.py` anyway, so a pure partner `cerebrium.toml` fails with `main.py not found` and the user has to `touch main.py` to get past a check that never applies. Hit while testing #74 against a real Deepgram deploy. ## Changes - Exempt configs with a partner service from the `main.py` check in `Validate`. - Add `validator_test.go` covering partner-only, partner + custom runtime, and the unchanged cortex cases. ## Verification `go test ./...` and `go vet ./...` green. Confirmed against a real project directory containing only `cerebrium.toml`: the pre-fix binary exits 1 with `main.py not found`, this branch reaches the deployment confirmation screen. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
jonoirwinrsa
added a commit
that referenced
this pull request
Aug 19, 2026
## Problem Partner deploys skip loading, zipping and upload — they go straight from create to build. The deploy checklist still rendered `Upload to Cerebrium` as a pending step under `StateCreatingApp`, advertising a stage that never runs. Same family as #74. ## Changes - Skip the upload step line for partner services in `View()`. - Assert the step is absent for partner deploys and still present for standard ones. ## Verification `go test ./...` and `go vet ./...` green; no golden files affected. The spurious line is visible in the checklist captured from a real Deepgram deploy while testing #74. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
--detachon a partner app — exits cleanly after create.🤖 Generated with Claude Code