Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/projectconfig/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@ func Validate(config *ProjectConfig) error {
}
}

// Check for main.py if not using custom runtime with dockerfile or custom entrypoint
// Check for main.py if not using custom runtime with dockerfile or custom entrypoint.
// Partner services run a prebuilt image and never package local files, so main.py
// is irrelevant for them.
hasDockerfile := config.CustomRuntime != nil && config.CustomRuntime.DockerfilePath != ""
hasCustomEntrypoint := config.CustomRuntime != nil &&
len(config.CustomRuntime.Entrypoint) > 0 &&
config.CustomRuntime.Entrypoint[0] != "uvicorn"
isPartnerService := config.PartnerService != nil

if !hasDockerfile && !hasCustomEntrypoint {
if !hasDockerfile && !hasCustomEntrypoint && !isPartnerService {
// Check if main.py exists
if _, err := os.Stat("main.py"); os.IsNotExist(err) {
if _, err := os.Stat("./main.py"); os.IsNotExist(err) {
Expand Down
53 changes: 53 additions & 0 deletions pkg/projectconfig/validator_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package projectconfig

import (
"os"
"path/filepath"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestValidateMainPy(t *testing.T) {
baseConfig := func() *ProjectConfig {
return &ProjectConfig{
Deployment: DeploymentConfig{Name: "test-app"},
}
}

t.Run("partner service does not require main.py", func(t *testing.T) {
t.Chdir(t.TempDir())

config := baseConfig()
config.PartnerService = &PartnerServiceConfig{Name: "deepgram"}

assert.NoError(t, Validate(config))
})

t.Run("partner service alongside custom runtime does not require main.py", func(t *testing.T) {
t.Chdir(t.TempDir())

config := baseConfig()
config.PartnerService = &PartnerServiceConfig{Name: "rime"}
config.CustomRuntime = &CustomRuntimeConfig{Entrypoint: []string{"uvicorn"}}

assert.NoError(t, Validate(config))
})

t.Run("cortex runtime still requires main.py", func(t *testing.T) {
t.Chdir(t.TempDir())

err := Validate(baseConfig())
require.Error(t, err)
assert.Contains(t, err.Error(), "main.py not found")
})

t.Run("cortex runtime passes when main.py exists", func(t *testing.T) {
tmpDir := t.TempDir()
require.NoError(t, os.WriteFile(filepath.Join(tmpDir, "main.py"), nil, 0644))
t.Chdir(tmpDir)

assert.NoError(t, Validate(baseConfig()))
})
}
Loading