Surface controller services left disabled by schedule_all_controllers

[Chaffelson]

Summary

When enabling, NiFi silently skips controller services that are INVALID (they cannot be enabled). canvas.schedule_all_controllers(..., "ENABLED") waited only for VALID controllers and then returned the activation entity, so the call could report success while leaving one or more services disabled — with no error, warning, or signal to the caller. For automated upgrade/enable flows this makes a real failure state easy to miss.

Change

schedule_all_controllers(pg_id, scheduled, strict=False):

• After the existing bulk-enable and wait, on the enable path it now re-checks for any controller left in a non-ENABLED state.
• If any remain: by default it logs a warning naming each (name, id, validation_status); with the new opt-in strict=True it raises ValueError instead — giving automation a deterministic signal.
• Default behaviour and return type are unchanged (still returns the ActivateControllerServicesEntity). The disable path is untouched.

Tests

tests/test_canvas.py (single-user profile):

• all-valid enable emits no warning;
• with an INVALID controller, the default path warns and still returns;
• with strict=True, it raises ValueError.

Uses the existing StandardSSLContextService fixture to produce a deterministic INVALID controller.

Verified locally: make test NIPYAPI_PROFILE=single-user PYTEST_ARGS="-k schedule_all_controllers" → 3 passed; make lint → flake8 clean, pylint 10.00/10.

[pvillard31]

Clean, backward-compatible fix that turns a previously silent failure into an explicit warning (or an opt-in raise via strict=True), backed by focused tests covering the all-valid, warning, and strict paths.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.97%. Comparing base (ba54425) to head (d0e8291).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   76.93%   76.97%   +0.03%     
==========================================
  Files          41       41              
  Lines        4869     4877       +8     
==========================================
+ Hits         3746     3754       +8     
  Misses       1123     1123              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.