feat: add Azure DevOps Flow Registry Client support#413
Merged
Conversation
* feat: add Azure DevOps Flow Registry Client support Add nipyapi.versioning.ensure_azuredevops_registry() to provision NiFi's native AzureDevOpsFlowRegistryClient end to end. Azure DevOps authenticates only via a Microsoft Entra service principal (OAuth2 client credentials), so the helper ensures the two required management (controller-level) controller services - a Web Client Service and an OAuth2 Access Token Provider - and wires them into the registry client. Supporting changes: - canvas: add create_management_controller() (controller-level create via the Controller API, unlike the process-group-scoped create_controller) and the idempotent ensure_management_controller() composer built on the existing get/update/schedule controller functions. - ci: add an "azuredevops" provider branch to ensure_registry (with NIFI_ADO_* environment fallbacks). - cli: add native Azure Pipelines output format (##vso[task.setvariable], auto-detected via the TF_BUILD environment variable). - tests: management-controller CRUD tests, Azure DevOps unit/validation tests, gated live integration tests, and teardown fixtures. * fix(canvas): make ensure_management_controller idempotent; verify real ADO auth - ensure_management_controller: re-applying properties to an existing, already-enabled management service failed because update_controller refuses to modify an enabled service without auto_disable. Pass auto_disable=True so the update disables, applies, and re-enables (with built-in rollback). - test_canvas: cover re-invocation with properties on an already-enabled service (previously only the no-properties idempotent path was tested). - test_ci: the live Azure DevOps test now lists buckets from the repo, forcing the SP OAuth2 token fetch + a live ADO API call, to prove the service principal actually authenticated rather than only that config is VALID. * fix(canvas): validate ensure_management_controller properties via prepare_controller_config * docs: document Azure DevOps registry + Azure Pipelines support
pvillard31
approved these changes
Jul 20, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 76.91% 77.12% +0.21%
==========================================
Files 41 41
Lines 4877 4954 +77
==========================================
+ Hits 3751 3821 +70
- Misses 1126 1133 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the Azure DevOps Flow Registry Client support on
main. This is the same, already-reviewed change from #412, which was inadvertently squash-merged into its stacked base branch (feat/nifi-2.10.0) rather thanmain, somainnever received it. This PR re-homes that exact delta onto currentmain(which already has the NiFi 2.10.0 client regen from #411).Contents (cherry-pick of the #412 squash)
ensure_azuredevops_registry()— provisions NiFi's nativeAzureDevOpsFlowRegistryClientend to end (Entra service-principal / OAuth2 client-credentials auth), wiring the required management controller services.create_management_controller()+ idempotentensure_management_controller()for controller-level (management) controller services.azuredevopsprovider branch inensure_registrywithNIFI_ADO_*env fallbacks.##vso[task.setvariable], auto-detected viaTF_BUILD).ci.rst,cli.rst, README, and the1.7.0changelog sections.Notes
git diff mainis exactly the 12-file ADO delta (no 2.10.0 noise) and all changed Python files compile..... Generated with Cortex Code