fix: restore GET /api/v1/users/me/learning-path route registration - #449
Merged
DeFiVC merged 1 commit intoAug 31, 2026
Merged
Conversation
…hainLearnOfficial#359) The route registration for /me/learning-path was already wired up to userController.getLearningPath (itself fully implemented, along with userService.getLearningPath), but was missing its closing ');' -- the route handler callback ran straight into the next app.get<...>( call with no statement terminator, a syntax error that broke parsing of the entire file. Fixes the syntax error and adds e2e coverage (auth rejection + shape of the returned recommendation array), matching the tolerance pattern already used by the other /me/* tests in this file for environments without a seeded user. Closes ChainLearnOfficial#351 Closes ChainLearnOfficial#359 Closes ChainLearnOfficial#365 Closes ChainLearnOfficial#364
|
@Mercy017 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The route registration for
GET /me/learning-pathinsrc/modules/users/user.routes.tswas already wired up touserController.getLearningPath— and that controller method, along withuserService.getLearningPath, was already fully implemented — but the route registration was missing its closing);. The handler callback ran straight into the nextapp.get<...>(call with no statement terminator, a syntax error breaking parsing of the entire file (and therefore the whole route module).Fixes the syntax error and adds e2e coverage for the endpoint (auth rejection, and the shape of the returned recommendation array), matching the tolerance pattern already used by the other
/me/*tests in this file for environments without a seeded user.Closes #351
Closes #359
Closes #365
Closes #364