Skip to content

fix: improve mobile nav toast and error boundary - #398

Merged
DeFiVC merged 1 commit into
ChainLearnOfficial:mainfrom
devfoma:fix/devfoma-ui-foundations-281-284
Aug 30, 2026
Merged

fix: improve mobile nav toast and error boundary#398
DeFiVC merged 1 commit into
ChainLearnOfficial:mainfrom
devfoma:fix/devfoma-ui-foundations-281-284

Conversation

@devfoma

@devfoma devfoma commented Aug 30, 2026

Copy link
Copy Markdown

Summary

  • improve mobile nav tap targets, focus rings, and icon-only accessible labels
  • bound and deduplicate toast queues with stable ids and an aria-live container
  • make the error boundary fallback safer and retry immediately without exposing raw error text by default

Closes #281
Closes #283
Closes #284

Tests

  • npm test -- src/tests/shared/error-boundary.test.tsx src/tests/shared/toast.test.tsx src/tests/layout/mobile-nav.test.tsx (blocked locally: dependencies are not installed; vitest not found)
  • npm run typecheck (blocked locally: dependencies are not installed; tsc not found)

@netlify

netlify Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploy Preview for chainlearn failed.

Name Link
🔨 Latest commit 7959fe9
🔍 Latest deploy log https://app.netlify.com/projects/chainlearn/deploys/6a93ec08aeb12000081c3617

@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@devfoma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@DeFiVC
DeFiVC merged commit 1ee95ae into ChainLearnOfficial:main Aug 30, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

. Add error-boundary.tsx improvements . Add toast-provider.tsx improvements . Add mobile-nav.tsx improvements

3 participants