chore: upgrade pnpm to v11#9299
Open
nazarhussain wants to merge 3 commits intounstablefrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project to pnpm v11, including the GitHub Action version, the packageManager field in package.json, and the migration of onlyBuiltDependencies to allowBuilds in pnpm-workspace.yaml. A critical issue was identified where pnpm-lock.yaml was not fully regenerated, resulting in a version mismatch (v9 instead of v10) and unsorted entries that will cause CI failures.
| overrides: | ||
| dns-over-http-resolver: ^2.1.1 | ||
| loupe: ^2.3.6 | ||
| nan: ^2.19.0 |
Contributor
There was a problem hiding this comment.
The lockfile version (at line 1) is still 9.0, which corresponds to pnpm v10. pnpm v11 introduces lockfile version 10.0. Additionally, the overrides section in this file is not sorted alphabetically (e.g., elliptic is at the end), whereas it is sorted in pnpm-workspace.yaml. This indicates the lockfile was not fully regenerated using pnpm v11. This discrepancy will cause CI failures because pnpm install --frozen-lockfile (as configured in .github/actions/setup-and-build/action.yml) will fail when it detects that the lockfile needs to be upgraded to v10. Please regenerate the lockfile by running pnpm install with pnpm v11.
Contributor
Author
There was a problem hiding this comment.
Tried to re-generate the new lock file and it also have the version 9.0
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Contributor
Author
|
For any reviewer, I would like you to pull and try setup this branch locally once, so we are sure there is no issue on any dev environment as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo was pinned to pnpm v10 (via
packageManagerinpackage.json) andpnpm/action-setup@v4in CI. Bringing both to the current major (v11 / action-setup v5) keeps uson a supported line and aligns with Node 24, which is already required by
engines.Description
packageManagerinpackage.jsontopnpm@11.0.0with the matching Corepack hash (hex SHA-512 of the npm tarball integrity).overrides:keys inpnpm-workspace.yaml(stray closing quotes that pnpm 11 surfaced asERR_PNPM_INVALID_SELECTOR).pnpm-lock.yamlagainst the corrected overrides.pnpm/action-setupreferences from v4 to v5 (commitfc06bc1257f339d1d5d8b3a19a8cae5388b55320) across 7 workflow / composite-action files. The orphan SHApreviously used in
setup-and-build/action.ymlis replaced with the canonical v5 SHA.No runtime behavior changes — tooling-only upgrade.
AI Assistance Disclosure
pnpm-workspace.yaml), compute the Corepack hash from the npm registry integrity, andlocate/update the seven
pnpm/action-setuppins. All changes were reviewed before commit.