Skip to content

DATA SCIENCE - Urban Delivery Demand Prediction 100%#1748

Open
blessy05 wants to merge 7 commits into
masterfrom
Blessy-Project-7-Urban-Delivery-Demand-Prediction
Open

DATA SCIENCE - Urban Delivery Demand Prediction 100%#1748
blessy05 wants to merge 7 commits into
masterfrom
Blessy-Project-7-Urban-Delivery-Demand-Prediction

Conversation

@blessy05
Copy link
Copy Markdown
Collaborator

@blessy05 blessy05 commented Apr 5, 2026

This PR includes preprocessing and feature engineering for the GraphSAGE model.

Changes made:

  • Cleaned dataset (handled missing values and duplicates)
  • Converted time columns to datetime format
  • Created new features:
    • order_hour
    • order_day
    • order_weekday
    • is_weekend
    • delivery_duration_mins
  • Prepared dataset for graph-based modelling
  • Implemented initial GraphSAGE model notebook

This forms the foundation for further model training and evaluation.

@blessy05 blessy05 requested a review from Litxinh123 April 5, 2026 01:50
@blessy05 blessy05 changed the title DATA SCIENCE - GraphSAGE Preprocessing & Feature Engineering DATA SCIENCE - Urban Delivery Demand Prediction Apr 5, 2026
@nadunhs25
Copy link
Copy Markdown
Collaborator

Great work! Keep it up

@nadunhs25 nadunhs25 closed this Apr 11, 2026
@nadunhs25 nadunhs25 reopened this Apr 11, 2026
@blessy05 blessy05 requested a review from manya0033 April 11, 2026 22:19
Copy link
Copy Markdown
Collaborator

@manya0033 manya0033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blessy05 , thanks for putting this together! I can see the GraphSAGE approach is ambitious and there's good thought behind the graph construction. A few things to address before I can approve:

The notebook is using talabat_enhanced_orders.csv from a local path, but the file isn't in the repo so reviewers can't run it. Since it's an external dataset (not from MOP), could you upload it to the DEPENDENCIES folder and update the path in the notebook accordingly, as per the PR checklist?
The notebook doesn't follow the use case template. There's no scenario, user story, introduction, dataset description, learning outcomes, or conclusion- just code cells with inline comments. Could you restructure it using the standard template? Our use cases are meant to read as step-by-step tutorials, so markdown explanations between sections are really important.

Small thing- the file should probably be renamed to follow the use case naming convention (check with the Use Case Naming Tool).

blessy05 and others added 6 commits May 17, 2026 13:59
Uploaded the external dataset to the DEPENDENCIES folder
Updated the dataset path so reviewers can run the notebook
Restructured the notebook using the required use case template
Added markdown explanations
@blessy05
Copy link
Copy Markdown
Collaborator Author

Hi @manya0033 , thanks for the feedback.

I’ve updated the PR by restructuring the notebook using the required use case format, adding markdown explanations, updating the dataset path, and adding the external dataset under DEPENDENCIES.

Please review again when you get a chance. Thanks!

@blessy05 blessy05 changed the title DATA SCIENCE - Urban Delivery Demand Prediction DATA SCIENCE - Urban Delivery Demand Prediction 100% May 17, 2026
@blessy05 blessy05 closed this May 17, 2026
@blessy05 blessy05 reopened this May 17, 2026
Copy link
Copy Markdown
Contributor

@molliefernandez-mentor molliefernandez-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blessy, some comments from me:

  • Please use the template provided in the GitHub to restructure your use case
  • You need to be calling your data using an API not a CSV file.
  • You need headings at each stage of the project explaining what you are doing and why, this is meant to e a tutorial explaining how to use the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants