Add Section 10: Deep Learning – LSTM and GRU Pedestrian Count Forecasting#1869
Add Section 10: Deep Learning – LSTM and GRU Pedestrian Count Forecasting#1869Thivainv wants to merge 23 commits into
Conversation
Litxinh123
left a comment
There was a problem hiding this comment.
Hi Thivain, looks good overall!
A few comments from my side:
- The scenario, introduction, and learning outcomes are clearly written and align well with the pedestrian climate impact prediction topic.
- The data preparation is strong, especially the hourly aggregation, climate-pedestrian merging, and time-series based feature engineering.
- The chronological train/validation/test split is appropriate for this forecasting task and helps avoid future data leakage.
- Model comparison is also well explained, with Baseline LSTM, Stacked LSTM, and GRU evaluated clearly using MAE, RMSE, and R².
- The optimisation approach looks reasonable, especially with dropout, EarlyStopping, and ReduceLROnPlateau supporting more stable model training.
Overall, the notebook is well structured and the GRU result is clearly justified as the best model. I don’t see any major issue from my side. Thanks!
NguyenMav
left a comment
There was a problem hiding this comment.
Hi Don, looks good on my end, didn't see anything glaringly wrong. Based on the documentation (https://github.com/Chameleon-company/MOP-Code/blob/master/datascience/documentation/Peer%20review%20work%20practices/Peer%20review%20work%20practices.pdf):
- Functionality: The code works end-to-end, no errors popped up for me.
- Reusability: The dataset seems to be updated in real-time, and the notebook have no errors despite these new additions.
- Readability: Comments in the code blocks were provided, and explanations of the outputs were included.
- Maintainability: The code is fairly easy to follow along, and changes can be made if the client (City of Melbourne) wants to do anything with the usecase.
- Others: Australian English used, templates followed, V2.1 API followed, usecase naming followed, step-by-step tutorial with the headings and sub-headers added.
…026/T1/UC00213_Urban_Pedestrian_Climate_Impact_Prediction directory
…026/T1/UC00213_Urban_Pedestrian_Climate_Impact_Prediction/test.txt
…026/T1/UC00213_Urban_Pedestrian_Climate_Impact_Prediction directory
Commit directly to the Thivain_t1_26 branch
…026/T1/UC00213_Urban_Pedestrian_Climate_Impact_Prediction/test.txt
Litxinh123
left a comment
There was a problem hiding this comment.
Hi Thivainv, looks good overall!
- The preprocessing workflow is well structured, especially the hourly aggregation, climate-pedestrian merging, and handling of datetime-based features.
- The feature engineering part is also strong, including lag features, rolling averages, and cyclical time encoding for sequential modelling.
- The visualisations are clear and help explain both pedestrian flow and climate behaviour effectively.
- The chronological train/validation/test split is appropriate for this forecasting task and helps avoid data leakage.
- The comparison between Baseline LSTM, Stacked LSTM, and GRU is presented clearly with suitable evaluation metrics.
- The tuning techniques such as dropout, EarlyStopping, and ReduceLROnPlateau are also implemented properly to improve training stability and model performance.
- All required files have been included for a more complete handover package
Overall, the notebook is well organised and the deep learning workflow makes sense for this prediction task. Happy to approve!
molliefernandez-mentor
left a comment
There was a problem hiding this comment.
@Thivainv Please make sure you delete the files in your Playground folder
Summary
This pull request adds the deep learning section (Section 10) to the urban pedestrian
climate impact prediction notebook. This section builds on the data cleaning, EDA,
time series analysis, and feature engineering completed in earlier sections by
implementing and comparing three recurrent neural network architectures for hourly
pedestrian count forecasting.
What Was Added