DATA SCIENCE | UC00209 Multi Modal Transport Demand Forecasting | 100% Complete#1942
DATA SCIENCE | UC00209 Multi Modal Transport Demand Forecasting | 100% Complete#1942siddhi-dabhade wants to merge 6 commits into
Conversation
manya0033
left a comment
There was a problem hiding this comment.
Hey Siddhi, the LSTM forecasting work looks solid - cells with good structure and explanations. A few things before I can approve:
The notebook filename should follow the use case naming convention (use the Naming Tool) - something like UC00XXX_Multi_Modal_Transport_Demand_Forecasting.ipynb.
The PR title should follow the format: "DATA SCIENCE | UC00XXX Multi Modal Transport Demand Forecasting | % Complete"
Please add a proper PR description with a summary of changes and reason for the pull.
|
Thank you for the feedback. Updated notebook naming convention, README documentation and cleaned repository structure. Please re-review the updated changes. |
molliefernandez-mentor
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Siddhi. Please make sure you get Manya's re-review before merging.
manya0033
left a comment
There was a problem hiding this comment.
Hi Siddhi, the changes look good. However, can please remove .vscode_backup/settings.json - this is an IDE config file and shouldn't be in the repo.
Thank you Mollie. |
Removed the .vscode_backup IDE configuration files from the repository and added .gitignore entries to prevent IDE configuration files from being tracked again. |
Reason for pull:
Final project completion pull request for the Multi-Modal Public Transport Demand Forecasting use case.
Summary of changes:
Updated changes:
Project status:
100% complete