Fix GitHub Actions CI: lockfile, Node 24 transition, ESLint flat config, lint errors#10
Merged
Merged
Conversation
…nv var Agent-Logs-Url: https://github.com/Chamudu/SwiftLogistics/sessions/6ee3e8b1-1662-4042-a627-5b55300b6a6f Co-authored-by: Chamudu <59128532+Chamudu@users.noreply.github.com>
…rd.jsx Agent-Logs-Url: https://github.com/Chamudu/SwiftLogistics/sessions/6ee3e8b1-1662-4042-a627-5b55300b6a6f Co-authored-by: Chamudu <59128532+Chamudu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GitHub Actions CI workflow for SwiftLogistics
Fix GitHub Actions CI: lockfile, Node 24 transition, ESLint flat config, lint errors
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing at the dependency install step (no committed lockfile) and would have subsequently failed on lint (broken ESLint flat config). Addresses both blockers and cleans up pre-existing lint errors that would surface once install was fixed.
Lockfile & workspaces
package-lock.jsonfrom.gitignoreand committed the generated root lockfile sonpm ciworksclient-appto rootpackage.jsonworkspacesarray (was missing, so workspace deps were never hoisted)CI workflow
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueat workflow level to opt into the upcoming Actions Node 24 runtime nowESLint flat config fix
eslint.config.jsreferenced a non-existent API path:Lint errors (pre-existing, unblocked by the above)
Navbar.jsx— removed unusedlogout,navigate,LogOut,useNavigateDashboard.jsx— removed deadgetEventIconfunction and its orphanedCheckCircle/AlertCircleimportsAuthContext.jsx/ThemeContext.jsx— addedeslint-disable-next-line react-refresh/only-export-componentson hook exports (standard context pattern, not an HMR bug)Orders.jsx— removed unusedeventparam from update callbackWarehouse.jsx— changedcatch (err)→catch {}(binding never read)socket.js— removed unusederrparam fromconnect_errorhandlerOriginal prompt
Fix GitHub Actions CI workflow for SwiftLogistics.
Context:
client-app, and validatedocker-compose.yml.Dependencies lock file is not found ... Supported file patterns: package-lock.json,npm-shrinkwrap.json,yarn.lock(because workflow usesnpm ciand/oractions/setup-nodecache expects a lockfile).Requirements:
package-lock.jsoncommitted to the repo (npm workspaces supported) sonpm ciworks deterministically.npm installand disable npm cache in setup-node to avoid lockfile requirement.env: FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueat workflow/job level.actions/checkout@v4andactions/setup-node@v4.npm run lint --workspace client-app.npm run build --workspace client-app.docker compose config -q.Deliverables:
Chamudu/SwiftLogisticsagainstmainwith the updated workflow and any necessary lockfile/changes.Notes:
package.jsonworkspaces andclient-appworkspace containinglintandbuildscripts.The following is the prior conversation context from the user's chat exploration (may be truncated):
User: check with the repos. and remake the cv
Assistant: ### Repo cross-check (what your GitHub proves vs what your CV claims)
1) SwiftLogistics (public) — strong match, keep as flagship
Repo: https://github.com/Chamudu/SwiftLogistics
Your CV claims (14+ services, REST/SOAP/TCP adapters, RabbitMQ, SAGA, JWT/RBAC, Socket.IO, React dashboard) are directly supported by the repo README:
test-auth.js,test-all-protocols.js,test-gateway.js)ARCHITECTURE.md,API.md, etc.)Improvement area (CV + repo alignment):
2) VillageCare (private) — strong project, but ATS risk
Repo is private: https://github.com/Chamudu/VillageCare (homepage shows deployed app)
Your CV claims (custom PHP MVC, middleware pipeline, CSRF, multi-role sessions, Leaflet/Chart.js, normalized DB) are supported by the README, including:
Big issue: because it’s private, recruiters can’t verify code.
Fix: in CV, mark it clearly as “Private repo (demo available)” and link the live site:
Also, your own docs mention a limitation: “some traits contain raw SQL; move to models.” That’s a real, credible improvement point you can talk about in interviews.
3) NexusEnroll (public) — CV currently overstates “3 microservices”
Repo: https://github.com/Chamudu/NexusEnroll
Your CV says: “three independent Flask microservices (Student, Course, Enrollment)”.
But your README shows:
So this is the main mismatch.
Fix (CV): rewrite NexusEnroll bullets to match the repo truth:
That makes you look honest and still strong.
4) c-parser (public) — good match
Repo: https://github.com/Chamudu/c-parser
Your CV claims recursive descent parser + lexical analysis + tests. Repo supports:
Improve: add one bullet emphasizing “e...
This pull request was created from Copilot chat.