Skip to content

Feedback Implementation - #39

Open
Charpell wants to merge 15 commits into
developfrom
Chore/Feedback-Implementation
Open

Charpell wants to merge 15 commits into
developfrom
Chore/Feedback-Implementation

Conversation

@Charpell

Copy link
Copy Markdown
Owner

What does this PR do?

This PR implements all changes required from the last defence session

Description of task completed?

Github workflow properly implemented
Adhered to Airbnb Style guide
The User Interface now fits in bigger Screen Resolution
Removed all console.log statement after deployment
Email notification has been fixed
Client test added
MIT license added
How should this be manually tested?
you can click here to signup

Screenshort

screen shot 2017-10-23 at 11 35 42 am

… component

 - the form for sending message has adjusted on big screen resolution

 [Finished]
- wrote class constructors for files formally in js
- delete NavDash component

[Finished]
- add heroku app link to Readme file

- change all instances of e to event

- remove all console.log statemnts

- change all instance of string concantenation to template strings

[Finished]
- set up jest frameowk enviroment
- write component tests for all components
- remove bug from the button that display user's tab in a group
- change the webpack enviroment to run from development to production

[Delivers]
    - start script in server with node
    - refactor test start script in travis.yml

    [Delivers]
- add js docs to methods in components

- remove all console.log statements

[Finished]
- write more tests for to improve coverage
- write jsdoc with identation
- re-name files to follow airbnb standard
- renamed function and method names to noun and verbs respectively
- protect all api routes with from Unauthorized access
- add FAQs to readme file
- change all es5 to es6 in the server

[Finished]
- fixed coverage and obtained coveralls badge

[Finished]
@Charpell Charpell changed the title Chore/feedback implementation Feedback Implementation Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant