Conversation
- installed express-validator to validate input field - re-name files to follow airbnb standard - refactored contribution write up in readme file [Finished]
- fixed issues with axios errors on the frontend - create helper function to handle unresolved promise from axios [Finished]
- write jsdoc for actions and api - write descriptive custom error message instead of a generic one - logs the user out after 24 hours - change variable names to a descriptive name [Finished]
- fixed timeout on how long a user should be logged in [finished]
- abstract bulky code into resubale component [finished]
- refactored navigation component into reuseable code [finished]
- Use Functions for all stateless component [finished]
- Create 2 folders in components file; container and presentation - Arrange all components into either container or presentation [finished]
- Write more component test - Write elaborate jsDoc - Use single responsibility principle in Message js [finished]
- Create middleware to validate users input and passed it to the route - Create methods to handle email and sms notification [finished]
- Write test for Store - Configure Travis to run client test [finished]
- Write JSDoc for AppStore [finished]
- make server side test more descriptive - server side return content of object - update jsdoc - reconfigure eslint settings - refactor client files [Finished]
- Generate test coverage report on codecov [finished]
- create middleware to check if a user is authenticated - create helper function to save users who have read a message - refactor server controller files to DRY codes - create a function to catch client errors [finished]
- update client side to and complete test - install and configure jswebToken [Finished ]
Charpell
changed the title
Charpell
force-pushed
the
Chore/second-feedback-implementation
branch
from
November 10, 2017 23:02
d2c0751 to
f7d39f8
Compare
- refactored every file for variable and function names - write more concrete test for server side [Finished ]
Charpell
force-pushed
the
Chore/second-feedback-implementation
branch
from
November 10, 2017 23:09
f7d39f8 to
038106c
Compare
Seunadex
reviewed
Nov 11, 2017
| "jsx-a11y", | ||
| "import" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
Kindly add a newline here and also do the same for most files here as they do not have a newline at end of file.
Seunadex
reviewed
Nov 11, 2017
| * @method onChange | ||
| * | ||
| * @description this method gets data from the store and sets to state | ||
| * |
There was a problem hiding this comment.
The indentation for your comments looks off, kindly fix it and it occurs in several files too
Seunadex
reviewed
Nov 11, 2017
| const Navigation = () => ( | ||
| <div> | ||
| <nav className="navbar navbar-inverse fixed-top" | ||
| style={{ borderRadius: '0px' }}> |
There was a problem hiding this comment.
Is there a reason for an inline styling here?
Owner
Author
There was a problem hiding this comment.
I have removed inline styling
Seunadex
reviewed
Nov 11, 2017
| "redirectEventId": null | ||
| }, | ||
| "myToken": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJkaXNwbGF5TmFtZSI6IkhoIiwiZW1haWwiOiJkZGRAZ3QubmpnIiwiaWF0IjoxNTA5NjMyNDkwLCJleHAiOjE1MDk2MzYwOTB9.2JpqQzrNOwzSAMKOgaAhUAXlUhUF7yQ8fkEXNFZ9CTg" | ||
| } No newline at end of file |
Charpell
force-pushed
the
Chore/second-feedback-implementation
branch
5 times, most recently
from
November 12, 2017 09:06
d43476b to
a7d7bd5
Compare
Charpell
force-pushed
the
Chore/second-feedback-implementation
branch
from
November 12, 2017 09:11
a7d7bd5 to
953cd4d
Compare
- removed inline styling - added newline to end of files [finished ]
Charpell
force-pushed
the
Chore/second-feedback-implementation
branch
from
November 12, 2017 09:27
953cd4d to
51d7f33
Compare
- Modify JsDoc template and styles [finished ]
chore(jsDoc): implement feedback
- changed error message for authentication from specific to generic error messages - refactor test to only check for the value of a property instead of checking if it exist. [finished ]
- write tests for functions in the AppStore - create seeders file to abstract mock data - remove old test snapshot [finished ]
- refactor Validate class - ignore autogenerated files - refactor Group Controller into Single responsibility principle [finished ]
- use code climate enviroment variable in travis [finished ]
- change filename in utils to AppAPI.js
- update the build status badge and coveralls badge to recent branch [finished ]
Feedback implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements all feedback gotten from the last defense session.
Description of task completed?