Resolves #1 & #2, added github workflow for build and lint, corrected lint recommendations for code.

.github/workflows/actions.yml

@@ -0,0 +1,31 @@
+name: C++ Build
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Docker build
+        run: |
+          docker build -t cpp-container .
+          docker run -i cpp-container
+
+  # make:
+  #   needs: build
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v3
+  #     - name: Build project
+  #       run: docker run -it cpp-container
+  # lint:
+  #   needs: make
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v3
+  #     - run: docker run -it cpp-container cpplint *.cpp *.h

.github/workflows/lint.yml

@@ -0,0 +1,15 @@
+name: C++ Lint
+
+on:
+  pull_request:
+    branches: [main]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Docker run & Lint
+        run: |
+          docker build -t cpp-container .
+          docker run -i cpp-container cpplint *.cpp *.h

GameDie.cpp

@@ -6,17 +6,17 @@
 
 // class constructor that seeds the random number generator
 GameDie::GameDie() {
-    srand(time(NULL));
+    r_seed = (unsigned int *) time(NULL);
     roll_counter.resize(FACES);
 
-    for (int i = 0; i < FACES; i++ )
-      roll_counter[i] = 0;
+    for (int i = 0; i < FACES; i++)
+        roll_counter[i] = 0;
 }
 
 // overloaded constructor
 GameDie::GameDie(unsigned int num) {
-    srand(time(NULL));
-    if ( num == 0 ) {
+    r_seed = (unsigned int *) time(NULL);
+    if (num == 0) {
         roll_counter.resize(FACES);
     } else {
         roll_counter.resize(num);
@@ -29,13 +29,13 @@ GameDie::GameDie(unsigned int num) {
 // generate a random number between 1-n where n is the counter size
 // (inclusive) and return it
 int GameDie::roll() {
-    int roll = rand_r() % roll_counter.size();
+    int roll = rand_r(r_seed) % roll_counter.size();
     roll_counter[roll]++;
     return roll + 1;
 }
 
 // return the count of how many times each face has been rolled, as a vector
 // where each face's count is at index face-1 (i.e. Face 1 is at index 0)
-vector <int> GameDie::get_distribution() {
+vector<int> GameDie::get_distribution() {
     return roll_counter;
 }

GameDie.h

@@ -6,16 +6,17 @@
 
 using std::vector;
 
-class GameDie{
+class GameDie {
  public:
   GameDie();
   explicit GameDie(unsigned int);
   int roll();
-  vector <int> get_distribution();
+  vector<int> get_distribution();
 
  private:
-  vector <int> roll_counter;
+  vector<int> roll_counter;
   static const int FACES = 6;
+  unsigned int *r_seed;
 };
 
 #endif  // GAMEDIE_H_

README.md

@@ -1,5 +1,7 @@
 # Roller
 
+[![C++ Build](https://github.com/AbhinavReddy-Dev/Roller/actions/workflows/actions.yml/badge.svg)](https://github.com/AbhinavReddy-Dev/Roller/actions/workflows/actions.yml)
+
 This repository provides a program that rolls a game die, such as the
 six-sided dice used in traditional dice game.
 

main.cpp

@@ -7,16 +7,15 @@ using std::cout;
 using std::endl;
 
 int main(int argc, char *argv[]) {
-  if ( argc != 2 || std::atoi(argv[1]) < 1 ){
+  if (argc != 2 || std::atoi(argv[1]) < 1) {
     cout << "Incorrect command.\n"
          << "Format: ./Roller <n>\n"
          << "--------------------\n"
          << "Arguments\n"
          << "--------------------\n"
          << "<n> - Required; a number 1 or greater representing the number\n"
          << "      of faces on the die being rolled\n";
-  } 
-  else {
+  } else {
     int faces = std::atoi(argv[1]);
     GameDie die(faces);
     cout << die.roll() << endl;