fix: localize short MFA removal code errors (M2-10400) - #2265
Merged
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
divbzero
approved these changes
Sep 14, 2026
divbzero
approved these changes
Sep 17, 2026
divbzero
left a comment
Contributor
There was a problem hiding this comment.
The latest commit looks good too, thanks @sricharan-varanasi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-10400
When MFA was enabled and a user attempted to remove it in French, submitting a verification or recovery code shorter than the required format displayed an English error message.
Changes include:
🪤 Peer Testing
Set the Admin language to French.
Enable MFA for an account.
Open Account Settings and select Remove MFA.
Submit a verification code with fewer than 6 digits.
Expected outcome: The French verification-code error is displayed:
Code de vérification invalide.Switch to the recovery-code option.
Submit a recovery code shorter than the required
XXXXX-XXXXXformat.Expected outcome: The French recovery-code error is displayed:
Code de récupération invalide.✏️ Notes
develop.✅ Checklist
Functionality
Testing
Security & Data Privacy
Logging/Monitoring
Performance
Readability
Change Safety
Backend changes are backwards compatible with old clients, or it is well known they are not and a deployment/rollout plan is in place. This includes backend changes being compatible with old mobile app versions, as well as applet versioning within Curious.Destructive database migrations are rolled out in stages. For example, renaming a column means adding a new column and migrating the existing data to that column in one deployment. Then monitoring to ensure that field isn’t used, and finally removing the old column in a separate deployment.