Default mashup CLI insert to draft; add --publish - #11
Merged
Conversation
Keep yarn generate:mashup off the public feed unless Chinmay passes --publish after reviewing the image. Uses existing visibility=draft (not a new enum). --dry-run is unchanged. Co-authored-by: Chinmay Kabi <chinmay@blend.to>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
yarn generate:mashupno longer inserts a published row. Default listing isvisibility=draft+moderation_status=visible(existing schema / feed filters). Pass--publishonly after reviewing the image.Burst (id 47) is out of scope here — XProd is unpublishing that row separately. This PR does not touch production data, generate images, or hit AI Gateway.
Why
Chinmay never publishes a mashup until he has reviewed the image. The CLI previously hardcoded
visibility: "published", which shipped Burst live by mistake.Public feed, sitemap, and locker all require
visibility = publishedandmoderation_status = visible. Draft is the existing unlisted value (generations_visibility_ck:draft | published). No new enum.Mapping
visibilitymoderation_status--publish)draftvisible--publishpublishedvisible--dry-run--publishis documented in--help.Files
src/lib/ops/mashup-cli.ts—--publishparse +mashupListingFields()src/lib/ops/mashup-run.ts— insert uses those listing fieldsscripts/generate-mashup.ts— draft vs published outputsrc/lib/ops/__tests__/mashup-cli.test.ts— default is not published; help includes--publishREADME.md— ops CLI docsTest plan
yarn test src/lib/ops/__tests__/mashup-cli.test.ts(17 passed)yarn generate:mashup --helpincludes--publish