fix: auto-detect platform to prevent silent data loss in Twitter-only simulations#193
Closed
ChinmayShringi wants to merge 1 commit intomainfrom
Closed
fix: auto-detect platform to prevent silent data loss in Twitter-only simulations#193ChinmayShringi wants to merge 1 commit intomainfrom
ChinmayShringi wants to merge 1 commit intomainfrom
Conversation
…ss in Twitter-only simulations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150
Problem
When a simulation is created with Twitter-only configuration (
enable_reddit=false), all data retrieval APIs silently return empty results because they default to looking up Reddit data.Root Cause
'reddit'in 3+ API locationsreddit_simulation.dbSolution
detect_platform_from_simulation()- checks which db files existget_platform_with_fallback()- intelligent fallbackAffected Endpoints
/<simulation_id>/profiles/<simulation_id>/profiles/realtime/<simulation_id>/postsLogic
reddit_simulation.dbandtwitter_simulation.dbredditfor backward compatibilityTesting
Impact
Eliminates silent data loss for Twitter-only simulations
Original PR: 666ghj/MiroFish#168
Original Author: @JasonOA888