Fix output ports to not have _oe signals#63
Closed
robtaylor wants to merge 1 commit into
Closed
Conversation
|
|
robtaylor
force-pushed
the
fix-output-port-oe
branch
from
352b4de to
8ce2ae9
Compare
Contributor
Author
|
reviewed ai generated parts, looks good |
gatecat
reviewed
Mar 20, 2025
| if hasattr(interface, 'o'): | ||
| m.d.comb += self.o.eq(interface.o) | ||
| if hasattr(interface, 'oe') and self._oe is not None: | ||
| m.d.comb += self.oe.eq(interface.oe) |
Contributor
There was a problem hiding this comment.
the mixing of self._oe and self.oe is a bit confusing here
Contributor
Author
There was a problem hiding this comment.
any suggestions? SiliconPlatformPort is public, so i think it has to be self._oe, but could be wrong!
gatecat
reviewed
Mar 20, 2025
| m.d.comb += self.port.o.eq(o_inv) | ||
| m.d.comb += self.port.oe.eq(self.oe) | ||
| # Only set oe for bidirectional ports | ||
| if self.direction is io.Direction.Bidir: |
Contributor
There was a problem hiding this comment.
this if doesn't need to be nested in the above one
Contributor
Author
|
@robtaylor check |
robtaylor
force-pushed
the
fix-output-port-oe
branch
from
8ce2ae9 to
09960aa
Compare
- Modified SiliconPlatformPort.__init__ to not create _oe signals for output ports - Changed IOBuffer.elaborate to only set oe for bidirectional ports - Updated wire method to check if _oe is None before setting it - Improved oe property error message to be more specific - Updated tests to verify output ports don't have oe signals - Fixed test_wire_output to work without an oe signal - Removed trailing whitespace for better code quality This fix addresses the hardware design principle that output ports should only have _o signals, not _oe (output enable) signals. Only bidirectional ports need _oe signals to control when they are driving vs. receiving. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
robtaylor
force-pushed
the
fix-output-port-oe
branch
from
09960aa to
c7b68da
Compare
lanserge
approved these changes
Jul 18, 2025
Contributor
|
I am now confused about the background of this PR. An output port with output enable is an entirely valid thing (it's possible to tristate a port without it being bidirectional, if you don't care about the input value while it's Hi-Z). This is what Amaranth implements too: https://github.com/amaranth-lang/amaranth/blob/5689b6bc5a55fe1e634883e3fdebe8981ae3981b/amaranth/lib/io.py#L349-L350 |
Contributor
Author
|
totally superceded now anyhow! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses the hardware design principle that output ports should only
have _o signals, not _oe (output enable) signals. Only bidirectional ports
need _oe signals to control when they are driving vs. receiving.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com