Aliases OPEN and CLOSED are causing compatibility issues with another libraries#45
Open
djairjr wants to merge 3 commits intoChris--A:masterfrom
Open
Aliases OPEN and CLOSED are causing compatibility issues with another libraries#45djairjr wants to merge 3 commits intoChris--A:masterfrom
djairjr wants to merge 3 commits intoChris--A:masterfrom
Conversation
Change the OPEN and CLOSED alias. This is causing many issues with other libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a gross change to the OPEN and CLOSED aliases in the Key.h, Keypad.h, and Keypad files.cpp because this is causing some incompatibilities with other libraries, because duplicate and inconsistent definitions happen. It took me a long time to realize that this was the problem.