Describe the CI this repo now actually has - #22
Merged
Conversation
The previous text promised an opt-in `validate.yml` calling the superproject's reusable `_validate-shapes.yml`. That was untrue when written — #415 flagged it as reading like an assurance — and it is still untrue now, just differently: what landed is a Fallout-driven `build.yml` running this repo's own `./build.sh`, which is the pattern SmartHome moved to. Documents the three targets, the fact that local and CI run the identical one, and that SCHEMA_RO_PAT's org visibility already covers this repo — confirmed rather than assumed, by the first green run. Adds two things a reader will otherwise discover the hard way: the portable validator is linux-x64 only, so `./build.sh` fails on macOS at RestoreValidator with a message telling you to skip it; and `BundlePaths()` is hand-maintained, so an unlisted asset directory is silently left out of the bundle instead of failing the build. Refs #415.
ChrisonSimtian
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous text promised an opt-in
validate.ymlcalling the superproject's reusable_validate-shapes.yml. That was untrue when written — #415 flagged it as reading like an assurance — and it is still untrue now, just differently: what landed in #21 is a Fallout-drivenbuild.ymlrunning this repo's own./build.sh.Documents the three targets, that local and CI run the identical one, and that
SCHEMA_RO_PAT's org visibility already covers this repo — confirmed by the first green run, not assumed.Adds two things a reader would otherwise find the hard way:
./build.shfails on macOS atRestoreValidatorBundlePaths()is hand-maintained — an unlisted asset directory is silently omitted from the bundle rather than failing the build