Stop teaching a group naming convention that will not match - #129
Merged
Conversation
The OIDC examples used "Homelab Admins,Media Admins" — a homelab's own group names in generic documentation, and as of that homelab's rename they no longer exist. Copying them would have produced a config that authenticates and then admits nobody, which fails closed and says nothing. Neutral examples now, plus what actually matters: the names must be whatever the provider puts in the claim. Krautwatch splits on commas only, so spaces are fine here — but other consumers of the same claim split on whitespace, which is why hyphenated names travel better. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A teammate session working on the Homelab repo flagged that its eight access groups were renamed to lowercase-hyphenated forms (
Homelab Admins→homelab-admins), because a group name travels inside thegroupsclaim and consumers re-split it with their own rules — Pulse splits on whitespace and commas, soHomelab Adminsarrived as two tokens and matched nothing, failing closed with no message.Krautwatch's blueprint entry is unaffected (it references blueprint entry ids via
!KeyOf, which did not change), but the documentation here was wrong twice over:Now neutral examples, plus the thing that actually matters: the names must be exactly what your provider emits in the claim. Also documented that Krautwatch splits the list on commas only — so a name with a space works here — while noting that other consumers of the same claim split on whitespace, which is why hyphenated names travel better. That is a nudge, not a rule we enforce: forcing our parser to split on whitespace would break legitimate names like
Domain Adminsfor everyone else.No behaviour change;
./build.sh Testgreen.