Skip to content

feat #113: save recommended exercise to library inline from report page #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristopherRotnes merged 1 commit into from
May 4, 2026
Merged

feat #113: save recommended exercise to library inline from report page #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 70 additions & 15 deletions app/src/components/Report.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { useState, useEffect, useRef, useMemo } from "react";
import { subDays, format } from "date-fns";
import { nb } from "date-fns/locale";
import { fetchSessionsForReport } from "../lib/db";
import { fetchSessionsForReport, saveLibraryExercise } from "../lib/db";
import { HeatmapBodySVG, BodySVG, MUSCLES, useIsMobile } from "../lib/bodymap.jsx";
import { buildRecMuscleMap, callClaude, logDevError } from "../lib/utils";
import { CLAUDE_MODEL_TEXT, buildPeriodRecommendPrompt } from "../lib/prompts";
import {
Tag, InlineLoading, DefinitionTooltip, Button, InlineNotification,
} from "@carbon/react";
import { AiGenerate, Add } from "@carbon/icons-react";
import { AiGenerate, Add, Checkmark } from "@carbon/icons-react";
import PageShell, { SectionLabel, AccentChip, StickyCta } from "./PageShell";
import { useNav } from "../lib/NavContext";

Expand Down Expand Up @@ -80,6 +80,9 @@
const [loadingRecs, setLoadingRecs] = useState(false);
const [recsError, setRecsError] = useState(null);
const [hoveredMuscle, setHoveredMuscle] = useState(null);
const [savedRecs, setSavedRecs] = useState(new Set());
const [savingRec, setSavingRec] = useState(null);
const [saveRecError, setSaveRecError] = useState(null);

const initialPrefill = useRef(prefill);
useEffect(() => {
Expand All @@ -89,7 +92,7 @@
if (p.selectedDays) setSelectedDays(p.selectedDays);
if (p.selectedTypes) setSelectedTypes(p.selectedTypes);
onPrefillConsumed?.();
}, []);

Check warning on line 95 in app/src/components/Report.jsx

View workflow job for this annotation

GitHub Actions / Lint, test and audit 

React Hook useEffect has a missing dependency: 'onPrefillConsumed'. Either include it or remove the dependency array. If 'onPrefillConsumed' changes too often, find the parent component that defines it and wrap that definition in useCallback

useEffect(() => {
setLoading(true);
Expand All @@ -114,6 +117,29 @@
return () => document.removeEventListener("keydown", fn);
}, [hoveredMuscle]);

const handleSaveRec = async (r) => {
setSavingRec(r.name);
setSaveRecError(null);
try {
await saveLibraryExercise({
name: r.name,
primary_muscles: r.primary || [],
secondary_muscles: r.secondary || [],
default_sets: null,
default_reps: null,
});
setSavedRecs(prev => new Set([...prev, r.name]));
} catch (err) {
if (err?.code === "23505") {
setSavedRecs(prev => new Set([...prev, r.name]));
} else {
setSaveRecError("Kunne ikke lagre øvelsen. Prøv igjen.");
}
} finally {
setSavingRec(null);
}
};

const getAdvice = async () => {
setLoadingRecs(true);
setRecs(null);
Expand Down Expand Up @@ -501,6 +527,15 @@
<div className="fade-in" style={{ marginTop: 12 }}>
<div style={{ background: "var(--surface-card)", border: "1px solid var(--border-subtle-wl)", borderRadius: "var(--r-tile)", overflow: "hidden", marginBottom: 10 }}>
<p style={{ ...labelStyle, margin: "14px 14px 10px" }}>Anbefalte øvelser</p>
{saveRecError && (
<InlineNotification
kind="error"
title="Feil:"
subtitle={saveRecError}
hideCloseButton
style={{ margin: "0 14px 8px" }}
/>
)}
{recs.map((r, i) => (
<div key={i} style={{
padding: "10px 14px",
Expand All @@ -518,19 +553,39 @@
</p>
{r.tip && <p style={{ fontSize: 12, color: "var(--cds-text-secondary)", margin: 0 }}>{r.tip}</p>}
</div>
<button
aria-label={`Legg til ${r.name} i biblioteket`}
onClick={() => onShowBibliotek()}
style={{
width: 28, height: 28, borderRadius: "50%",
background: "var(--accent)", border: "none", cursor: "pointer",
color: "#fff", fontSize: 20, lineHeight: "28px",
display: "flex", alignItems: "center", justifyContent: "center",
flexShrink: 0,
}}
>
<Add size={16} />
</button>
{savedRecs.has(r.name) ? (
<button
disabled
aria-label={`${r.name} er lagret i biblioteket`}
style={{
width: 28, height: 28, borderRadius: "50%",
background: "var(--cds-layer-02)", border: "none", cursor: "default",
color: "var(--cds-text-secondary)",
display: "flex", alignItems: "center", justifyContent: "center",
flexShrink: 0,
}}
>
<Checkmark size={16} />
</button>
) : (
<button
aria-label={`Legg til ${r.name} i biblioteket`}
onClick={() => handleSaveRec(r)}
disabled={savingRec === r.name}
style={{
width: 28, height: 28, borderRadius: "50%",
background: savingRec === r.name ? "var(--cds-layer-02)" : "var(--accent)",
border: "none",
cursor: savingRec === r.name ? "default" : "pointer",
color: savingRec === r.name ? "var(--cds-text-secondary)" : "#fff",
display: "flex", alignItems: "center", justifyContent: "center",
flexShrink: 0,
opacity: savingRec === r.name ? 0.5 : 1,
}}
>
<Add size={16} />
</button>
)}
</div>
))}
</div>
Expand Down
Loading