feat(#123): Settings view — consolidate header to 6 icons#126
Merged
Conversation
- Create Settings.jsx with five sections: Utseende (theme toggle + body map preview), Konto (email + logout), Om appen (version + changelog), Kontakt, Språk (placeholder) - Remove theme toggle and logout from PageShell header; replace with EventSchedule (placeholder) and Settings nav icons - Remove version footer button and ChangelogModal from PageShell - Add onShowSettings to NavContext and "settings" view in App.jsx Closes #123 https://claude.ai/code/session_01NSBiZxpgCv2kUVt9MUcWkH
Carbon Button renders as <a> automatically when href is provided. https://claude.ai/code/session_01NSBiZxpgCv2kUVt9MUcWkH
ChristopherRotnes
changed the title
12 tasks
Staging envs were not being cleaned up when PRs were closed because the close_pull_request_job was gated by the app/** paths filter. Moving it to a dedicated workflow that fires on all PR closes targeting master or dev, regardless of which files changed. https://claude.ai/code/session_01NSBiZxpgCv2kUVt9MUcWkH
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-090dfd003-126.westeurope.7.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a dedicated Settings view reachable via a new Settings icon in the top bar. Removes theme toggle and logout from the header and consolidates them into Settings. EventSchedule icon added as visual placeholder to achieve the 6-icon layout — destination TBD in a follow-up issue.
Changes
Settings.jsx— new view with five sections: Utseende (theme toggle + body map preview), Konto (email + logout), Om appen (version + changelog), Kontakt, Språk (placeholder)PageShell.jsx— header rebuilt with 6 icons (Camera, RecentlyViewed, Analytics, Book, EventSchedule, Settings); version footer button and ChangelogModal removedApp.jsx— settings view wired into router + NavContext viaonShowSettingsAcceptance criteria
Out of scope
Closes #123