fix: use explicit nullable types for PHP 8.4 compatibility#248
Merged
apotek merged 2 commits intoChromaticHQ:5.xfrom Feb 23, 2026
Merged
fix: use explicit nullable types for PHP 8.4 compatibility#248apotek merged 2 commits intoChromaticHQ:5.xfrom
apotek merged 2 commits intoChromaticHQ:5.xfrom
Conversation
Fix implicitly nullable parameters in GitHubStatusTrait deprecated in PHP 8.4. Also add PHP 8.4 and 8.5 to the CI matrix.
Preserves the exception chain for improved debuggability.
apotek
approved these changes
Feb 23, 2026
Contributor
apotek
left a comment
apotek
left a comment
There was a problem hiding this comment.
Correctly marks the properties as nullable. Thank you for doing this.
Passes tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix implicitly nullable parameters in GitHubStatusTrait deprecated in PHP 8.4. Also add PHP 8.4 and 8.5 to the CI matrix.
Motivation / Context
Fix deprecations and include latest PHP versions in testing.
Testing Instructions / How This Has Been Tested
CI should pass.